🇦🇺Australia @jordan.jamous

Is this going to land in 10.3.x?

+1 RTBC

Attached is a re-roll against 10.3.x

Tests are failing for modules/search/tests/src/Functional/SearchRankingTest.php

phpunit ./web/core/modules/search/tests/src/Functional/SearchRankingTest.php
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

E.                                                                  2 / 2 (100%)

Time: 00:10.277, Memory: 8.00 MB

There was 1 error:

1) Drupal\Tests\search\Functional\SearchRankingTest::testRankings
Behat\Mink\Exception\ElementNotFoundException: Select with id|name|label|value "edit-rankings-views-value" not found.

/var/www/html/drupal/web/core/tests/Drupal/Tests/WebAssert.php:234
/var/www/html/drupal/web/core/modules/search/tests/src/Functional/SearchRankingTest.php:130

Running tests on 10.1.x

#5 Worked well on 10.1.x

@beloglazov91 this issue is fixed/closed, please don't upload patches to this issue.
if you have other concerns, you may want to create a new issue, reference this ticket, then add your details and fixes.

RTBC +1 on 10.1.*

@nmoti use the patch from this issue https://www.drupal.org/project/drupal/issues/3324225#comment-15251460 ✨ Support CKEditor 5's table properties and cell properties plugins in Full HTML Fixed

jordan.jamous → changed the visibility of the branch 3340154-link-widget-throws-exception-update to active.

jordan.jamous → created an issue.

Patch update

The patch file as well

jordan.jamous → created an issue.

Thanks, the new patch/MR works well.

Thanks worked for using non Latin language (Greek) unlike the patch in #3323286

For me, as I am trying to send emails in Greek, adding ICONV_MIME_DECODE_CONTINUE_ON_ERROR ignores all none Latin characters, which again I end up with an empty subject. Patch at #3331181 🐛 Empty subject if any non-latin characters used Needs review worked for me

Hi @drunken monkey, I confirm that 8.x-1.31 fixes the issue for me, thank you.

Thanks everyone, RTBC here as well. I am trying to give it a nudge, therefore I created a merge request out of #4 patch. Thank you.

jordan.jamous → made their first commit to this issue’s fork.

@liam-morland Done, thanks.

jordan.jamous → changed the visibility of the branch 3404776-typeerror-unsupported-operand to active.

jordan.jamous → changed the visibility of the branch 3404776-typeerror-unsupported-operand to hidden.

jordan.jamous → changed the visibility of the branch 3404776-typeerror-unsupported-operand to hidden.

Trying again

The patch

jordan.jamous → created an issue.

@admirlju thanks, great work.

Thanks @Chizh273 for patch, I tested it and it works fine. The only reason why I won't RBTC it that it is failing tests.
I checked the MR, there is a composer error relates to composer.lock file error, which I think it is not related to this patch.

I am re-uploading your diff as a patch file, and running tests the legacy way.

Thank you guys for the swift response. This is the latest MR as a patch file

The patch

jordan.jamous → created an issue.

Problem still exists in Drupal 10.1.4, has anyone found a solution for this matter? #22 did't work for me. My setup is similar to the setup explained in the issue description. Thanks

The patch

jordan.jamous → created an issue.

Thanks for the patch, It didn't work for me, but I assume it is for an older version of select_or_other, in my case, I have a custom entity with select list property, which gets ignored in mustBeValidatedByCore() because it doesn't want to deal with select list base fields!

I guess this would be a re-roll.

jordan.jamous → created an issue.

jordan.jamous → created an issue.

EKAN 1.x will not support D10, please use 2.x.

We would appreciate a new release for 4.4.x-dev here as well, thanks for your efforts.

Thanks @aangel, I think you are correct, 4.4.2 still isn't compatible but dev is.
The release issue is being followed up here https://www.drupal.org/project/responsive_menu/issues/3297963#comment-15... 📌 Automated Drupal 10 compatibility fixes Fixed

jordan.jamous → created an issue.

jordan.jamous → created an issue.

@Spokje yeah thanks mate, I did that by mistake and reverted it. Apologies.

Retagging and revert version

Rerolling from #459 for 9.1.x

Trying to re-roll on 9.1.x