- 🇧🇷Brazil igoragatti
I've updated the patch so that the info.yml file shows the compatibility with Drupal 10.
- 🇺🇸United States protitude
I have tested the #4 patch on both my Drupal 9 and a fresh Drupal 10 site, and I did not encounter any issues. The patch seemed to work seamlessly on both sites.
- 🇺🇸United States kthull Fort Wayne, Indiana
#4 applies, but I get the following warnings via upgrade status:
File Name
responsive_menu/responsive_menu.libraries.ymlLine
0Error
The 'responsive_menu.superfish' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256 →File Name
responsive_menu/tests/themes/responsive_menu_theme_test_nobp/responsive_menu_theme_test_nobp.info.ymlLine
0Error
Add core_version_requirement: ^8 || ^9 to designate that the extension is compatible with Drupal 9. See https://drupal.org/node/3070687.. - last update
over 1 year ago CI error - 🇺🇸United States stevenlafl
Here's one with the test theme core_version_requirement as well.
- First commit to issue fork.
- last update
over 1 year ago 20 pass, 1 fail - 🇮🇳India yogeshsevak
After applying #7, the upgrade status module is still showing the below error.
The 'responsive_menu.superfish' library is depending on a deprecated library. The core/jquery.once asset library is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead. See https://www.drupal.org/node/3158256 →
Providing updated patch with fix. All errors and warnings shown by the Upgrade Status module have been fixed in this patch.
Please review.
The last submitted patch, 9: responsive-menu-d10-compatibility-3297963-9.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
over 1 year ago 5:45am 11 May 2023 - 🇮🇳India yogeshsevak
Providing patches for below versions.
For 4.4.x-dev responsive-menu-d10-compatibility-3297963-9.patch →
For 4.4.2 responsive-menu-d10-compatibility-3297963-11.patch →Please review.
- Status changed to Needs review
over 1 year ago 5:49am 11 May 2023 - 🇯🇵Japan ilfelice
Howdy,
After applying the patch in #7, I can install the module in Drupal 10, and confirm that it works as expected.
- 🇺🇸United States mikemadison Seattle, WA
it would be awesome if we could get this merged. this is the last blocking item on one of my sites to get to d10!
- First commit to issue fork.
- 🇬🇧United Kingdom maria.y
Patch #7 works for me too. :)
Thanks in advance to the most awesome maintainers.
- last update
over 1 year ago 16 pass, 1 fail - 🇮🇹Italy tanc Italy
Tests are failing due to bartik and stable no longer being included. Updated tests and will hopefully pass.
- last update
over 1 year ago Composer require failure The last submitted patch, 18: responsive-menu-d10-compatibility-3297963-18.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to RTBC
over 1 year ago 6:13pm 5 June 2023 - 🇮🇹Italy tanc Italy
Drupal.org's tests are very confusing... They pass locally but fail on d.o's infrastructure. I'm tempted to commit this as I've tested locally and then open another issue to fix the tests
- Status changed to Fixed
over 1 year ago 5:35am 6 June 2023 - 🇮🇹Italy tanc Italy
Thanks everyone for your help. I've committed the patch to 4.4.x branch and created this issue to fix the failing test 📌 Fix failing test Needs review
As soon as that test is fixed we can look at a release.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 8:32am 30 June 2023 - 🇩🇪Germany dbielke1986
Is there a chance to push the changes to a new release? We need to update our page to D10 and this module is one which is incompatible to D10.
- 🇦🇺Australia jordan.jamous
We would appreciate a new release for 4.4.x-dev here as well, thanks for your efforts.