Notice: iconv_mime_decode(): Detected an illegal character in input string in Maillog->mail()

This patch fix Notice: iconv_mime_decode() but does not solve the problem with non-latin subject

I got mentioned notice and empty subject in maillog if email address contains "+" sign.
Patch #7 solved my issue, thanks.

In this current issue, the patch in comment #7 is using the following for line 45 in the file src/Plugin/Mail/Maillog.php:

$record->subject = mb_substr(iconv_mime_decode($record->subject, ICONV_MIME_DECODE_CONTINUE_ON_ERROR), 0, 255);

And in the #3331181, the MR is using the following for line 45:

$record->subject = mb_substr($record->subject, 0, 255);

So in #3331181, the decoding with iconv_mime_decode was completely removed instead of continuing on error in the patch here in #7.

I tested both patch and they work for me.

But which one would be best to cover all use cases?

Thanks to all contributing to this great module!

For me, as I am trying to send emails in Greek, adding ICONV_MIME_DECODE_CONTINUE_ON_ERROR ignores all none Latin characters, which again I end up with an empty subject. Patch at #3331181 🐛 Empty subject if any non-latin characters used Needs review worked for me

My latest MR #15 should handle nicely both raw or mime encoded subject strings.

We only call iconv_mime_decode if subject is a mime encoded string (checked with regexp).

An alternative solution from super_romeo that I think is a better approach: 🐛 Empty subject if any non-latin characters used Needs review

I've committed #17, thanks everyone!

DamienMcKenna → closed merge request !15

Hi, sadly you get things like this now, don't know if it's really better than an empty string ;)

mably → reopened merge request !15

mably → closed merge request !15

mably → changed the visibility of the branch 3323286-notice-iconvmimedecode-detected to active.

mably → reopened merge request !15

mably → closed merge request !15

Thank you for reporting this, I was mistaken in my decision.

I've committed the merge request with some minor additions for documentation.

That's perfect, thanks a lot!

Automatically closed - issue fixed for 2 weeks with no activity.