- ๐บ๐ธUnited States jjmackow
I'm very interested in seeing the table properties come back. Could this be re-opened again please?
- ๐บ๐ธUnited States guymandude
Another frustrated CKEditor user that wonders why the Table Cell functionality was removed from V5. Put it back please.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
@jjmackow and @GuyManDude this issue has been worked on in โจ Support CKEditor 5's table properties and cell properties plugins in Full HTML Fixed and is now (currently) RTBC. This will land in Drupal Core 10.2.x and 11.x!
- ๐ฎ๐ณIndia sagarTiwari
I verified it the diff file provided on #1 works fine
Below are before and after screenshots
Before applying patch
After applying patch
Here providing patch for the diff file for ease of use.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
This feature already landed... not sure why you are testing the patch from this issue which is far from complete as opposed what actually was implemented in โจ Support CKEditor 5's table properties and cell properties plugins in Full HTML Fixed
- ๐บ๐ฆUkraine vasyok
Theanx, gues! Patch worked,
Maybe someone write how to add CSS class to table in properties window? - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Hiding all files. Refer to the referenced issue for the proper and complete integration of this issue. You should not be using any patch from this issue..
Adding classes to the table is something else as what this issue is trying to fix.
- ๐ซ๐ทFrance Nicolas S. Lyon, France
It's ok for with a Drupal 10.1.5 and patch 16
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
@Nicolas S. For Drupal 10.1.5 please use the patch from here: https://www.drupal.org/project/drupal/issues/3324225#comment-15251460 โจ Support CKEditor 5's table properties and cell properties plugins in Full HTML Fixed
Again, you should not use patches from this issue.
- ๐บ๐ธUnited States marget.long
marget.long โ made their first commit to this issueโs fork.
#2 worked on 10.2.4. Thank you!
@BramDriesen This issue should be reopened. The table options do not appear without disabling "Limit Allowed..." which is a security risk. The configurations were not properly added in the MR: https://git.drupalcode.org/project/drupal/-/blob/93aa6832a5841aaed32d84b....
- ๐ฆ๐บAustralia jordan.jamous
@nmoti use the patch from this issue https://www.drupal.org/project/drupal/issues/3324225#comment-15251460 โจ Support CKEditor 5's table properties and cell properties plugins in Full HTML Fixed
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
@nmonti First of all, the patch here is incomplete if you look at what got committed in core.
There are multiple reasons why you need to disable Limited Allowed HTML. I suggest you to read all comments (or at least #2 to #11 ish in the parent issue) where this is clarified. This or the parent issue will not be re-opened for that as it's working as designed. If you do want to continue the discussion there is this issue โจ Allow inline style to certain html elements despite of "Limit allowed HTML tags and correct faulty HTML" filter turned on Active .
The configurations were not properly added in the MR:
That's because the patch here is an incorrect implementation. It should not be added like that.
@BramDriesen #7 on that thread says not to disable it, and the probability of it being disabled is "0%".
To each their own, but I'm going to use what works for me (this patch) and wait for CKEditor5 to be properly implemented in Drupal without exposing ourselves to security risks.
#7 on the parent thread, and the following issue having zero traction, indicate this setting should remain enabled. https://www.drupal.org/project/drupal/issues/3424790 โจ Make 'Limit allowed HTML tags and correct faulty HTML' not accessible if CKEditor 5 is chosen Active
@joran.jamous I shouldn't need a separate plugin to activate core CKEditor5 functionality. The WYSIWYG experience has regressed tremendously since CKEditor4 and it's frustrating.
(Our team has been trudging through this D10 upgrade for months so apologies for any tone. I just want it to be done!!)