- ๐บ๐ธUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request โ as a guide.
At this time we will need a D10 version of the patch.
Also D10 should be checked to see if there are additional instances of \Drupal::request() that need to be addressed.
Thanks
- ๐บ๐ธUnited States smustgrave
Still seem to be instances
ViewExecutable
DbUpdateControllerNot sure if entities or traits count.
- ๐ฎ๐ณIndia Hardik_Patel_12 India
Updating deprecation message for drupal:11.0.0.
The invocation of \Drupal::request() is located within a static function in DbUpdateController, making it uncertain whether it should be modified. - last update
about 1 year ago 25,993 pass, 1,820 fail - Merge request !6094Issue #3123224: Replace non-test usages of \Drupal::request() with IoC injection โ (Open) created by Hardik_Patel_12
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Merge request !83123123224: Replace non-test usages of \Drupal::request() with IoC injection & fixed conflicts โ (Open) created by samit.310@gmail.com
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3123224-replace-non-test-usages to hidden.
- Status changed to Needs review
8 months ago 9:01am 6 June 2024 - Status changed to Needs work
8 months ago 1:29pm 6 June 2024 - Status changed to Needs review
8 months ago 10:20am 10 June 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
Hi @smustgrave,
Please review.
Thanks
Samit K. - Status changed to Needs work
8 months ago 2:37pm 13 June 2024 - ๐บ๐ธUnited States smustgrave
Left a comment but not sure we can fully remove parameters and add new ones without doing a BC step.