Convert HandlerAllTest into a kernel test

Created on 20 March 2019, over 5 years ago
Updated 12 February 2024, 9 months ago

Problem/Motivation

HandlerAllTest makes no HTTP requests but is a functional test.

Proposed resolution

Convert HandlerAllTest into a kernel test.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

📌 Task
Status

Fixed

Version

10.2

Component
Views 

Last updated about 4 hours ago

Created by

🇷🇴Romania claudiu.cristea Arad 🇷🇴

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Pipeline finished with Success
    10 months ago
    Total: 3663s
    #77982
  • Status changed to Needs review 10 months ago
  • Status changed to Needs work 10 months ago
  • 🇺🇸United States smustgrave

    1 nitpicky item. But how we have done other conversions think it should be included.

  • Pipeline finished with Success
    10 months ago
    Total: 595s
    #80539
  • Status changed to Needs review 10 months ago
  • Status changed to RTBC 10 months ago
  • 🇺🇸United States smustgrave

    Thanks @Spokje

  • Status changed to Needs work 10 months ago
  • 🇬🇧United Kingdom longwave UK

    I repeated #4 and there is still a difference (but also see how much quicker the kernel test is):

    Time: 00:11.982, Memory: 4.00 MB
    
    There was 1 error:
    
    1) Drupal\Tests\views\Functional\Handler\HandlerAllTest::testHandlers
    This test printed output: int(35)
    

    vs

    Time: 00:02.926, Memory: 4.00 MB
    
    There was 1 error:
    
    1) Drupal\Tests\views\Kernel\Handler\HandlerAllTest::testHandlers
    This test printed output: int(31)
    

    Maybe we need some additional coverage to ensure all handlers in core are included?

  • Status changed to Needs review 10 months ago
  • 🇳🇱Netherlands Lendude Amsterdam

    Added some more modules

    This test printed output: int(37)
    

    Checked all modules that implement hook_views_data, think this get all of the ones that don't need extra handling or just reuse existing plugins...I think

  • Pipeline finished with Success
    10 months ago
    #82492
  • Status changed to RTBC 10 months ago
  • 🇺🇸United States smustgrave

    Feedback appears to be addressed.

  • 🇳🇱Netherlands spokje

    Do we need either a follow-up or some more work in here to make sure that adding modules with views handlers to core, but not to this test. would break either this test or another new test?

  • 🇬🇧United Kingdom catch

    I think a follow-up to add a test coverage test is probably a good idea, the old test would not have caught new modules either so not a requirement for me, but useful to have.

    • catch committed b604d68a on 10.2.x
      Issue #3041755 by Hardik_Patel_12, claudiu.cristea, Lendude, Spokje,...
    • catch committed eb2baa20 on 11.x
      Issue #3041755 by Hardik_Patel_12, claudiu.cristea, Lendude, Spokje,...
  • Status changed to Fixed 10 months ago
  • 🇬🇧United Kingdom catch

    Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024