- @hardik_patel_12 opened merge request.
- Status changed to Needs review
10 months ago 10:01am 16 January 2024 - Status changed to Needs work
10 months ago 7:25pm 18 January 2024 - 🇺🇸United States smustgrave
All new functions or parameters should be typehinted with returns
- Status changed to Needs review
10 months ago 6:24am 19 January 2024 - Status changed to RTBC
10 months ago 6:27pm 23 January 2024 - 🇺🇸United States smustgrave
Feedback appears to be addressed and I didn't see any other instances of coverage for this.
- Status changed to Needs work
10 months ago 11:10am 2 February 2024 - 🇳🇿New Zealand quietone
I'm adding a reminder that evidence of a code review is expected when setting an issue to RTBC. For this issue, all I see is comment #32 which mentions return types. I would expect to see some comment about the test coverage and the the supplied test cases are sufficient.
Setting to NW for the comments in the MR.