Dependency injection in permission callbacks

Updated the DI in permission callbacks for TaxonomyPermissions.php, a change record is still needed.

> This will also need a change record. Thanks!

I don't think this needs a CR - the class is internal. It's not even a service.

Removing unused Drupal\Core\StringTranslation\TranslationInterface and unused $this->stringTranslation service injection it is not used in file.

The string translation service is used many times in this file, every time $this->t() is called. The StringTranslationTrait takes care of it if it is missing, but it's hacky and renders the class more difficult to test. It is there for cases where dependency injection is not available or for developer that do not know how to do it, but it should be injected when possible: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

Rebased, updated to use autowiring and constructor property promotion, changed to not inject entity storage, added CR and deprecation message although I somewhat agree this is overkill.

Opened 🌱 META: Use dependency injections in permission callbacks Active to track others

Change here though seems pretty straightforward though, good deprecation.

LGTM

Setting to needs work for an item in the MR. Also, this needs a title update.

I see that xjm asked for a Meta to make these changes in other permission callback but I wonder if these can all be done at once. Not sure.

I updated the title and took care of the cr link.

Title seems good now, change still looks good.

catch → closed merge request !6098

Committed/pushed to 11.x, thanks!

I jumped the gun and deleted the CR because we don't need change records for constructor bc, then realised that we do need them because phpcs demands one for all depecation messages. I really think we need to change that requirement, but for now I made a new CR and a redirect from the old one to the new one.

Automatically closed - issue fixed for 2 weeks with no activity.

Amending attribution.