The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
almost 2 years ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 7:18am 8 January 2024 - last update
about 1 year ago Patch Failed to Apply - 🇮🇳India Hardik_Patel_12 India
Rerolling patch against Drupal 11.x and adding interdiff.
- last update
about 1 year ago 25,990 pass, 1,815 fail - Merge request !6060Issue #3155495 Refactor system/Kernel/Theme/ThemeTest::testThemeDataTypes → (Open) created by Hardik_Patel_12
- last update
about 1 year ago Patch Failed to Apply - Status changed to RTBC
about 1 year ago 5:54pm 10 January 2024 - 🇺🇸United States smustgrave
Breaking apart the test seems fine. Not coverage lost.
- Status changed to Needs work
about 1 year ago 6:42am 14 January 2024 - 🇳🇿New Zealand quietone
@mondrake, thanks for the explanation given in #9. That made this much easier to review.
I think a comment can be improved but it would be fine to add this. However, according to GitLab this can be merged but the diff does not apply to HEAD. Not sure why that is. So, since this needs work I added a suggestion for the comment.