Convert ServiceDeprecationTest into a Kernel test

Created on 17 January 2024, 5 months ago
Updated 20 January 2024, 5 months ago

Problem/Motivation

Drupal\FunctionalTests\Core\Container\ServiceDeprecationTest Makes no HTTP requests but is a functional test.

Proposed resolution

Convert Drupal\FunctionalTests\Core\Container\ServiceDeprecationTest into a Kernel test.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Closed: won't fix

Version

11.0 🔥

Component
Other  →

Last updated about 11 hours ago

Created by

🇮🇳India Hardik_Patel_12 India

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Hardik_Patel_12
  • 🇳🇱Netherlands Spokje

    Not sure why we're opening up an issue when both the META and the class PHPDoc explicitly state:

    Note: this test must be a BrowserTestBase so the container is properly compiled.

  • 🇮🇳India Hardik_Patel_12 India

    Conveying uncertainty, there appears to be a plausible opportunity to convert it into a kernel test case. Furthermore, I have removed the links integrated into the parent issue. Any insights or feedback on this approach would be highly appreciated.

  • 🇳🇱Netherlands Spokje
  • 🇬🇧United Kingdom longwave UK

    As the comment says this must be a functional test in order to ensure that the deprecations are correctly triggered at runtime, kernel tests do not use a compiled container and so they are not a valid test in this case.

  • Status changed to Closed: won't fix 5 months ago
  • 🇳🇱Netherlands Spokje

    Thanks @longwave for confirming.

    Let's pull the trigger.

Production build 0.69.0 2024