- ๐ฌ๐งUnited Kingdom adamps
Thanks for the report and patch. I'm the only active maintainer and I don't use multi-lingual๐ - it would be great if someone else could test.
The patch looks correct to me, it could be tidied up a little:
- Instead of
\Drupal::service('language_manager');
use\Drupal::languageManager()
- Use the
$language_manager
variable within the loop - Can the translation really be missing a name? Even if yes, can simplify the code with ?? operator.
- The 'sanitize' option was removed in Drupal 8๐ - as we are changing the code, let's delete that part
- Instead of
- Status changed to Needs review
over 1 year ago 10:39pm 10 October 2023 - last update
over 1 year ago 59 pass - ๐บ๐ฆUkraine vlad.dancer Kyiv
Here is patch with addressed comments from #6
- Status changed to Needs work
over 1 year ago 10:34am 11 October 2023 - ๐ฌ๐งUnited Kingdom adamps
Great thanks. All patches now need to go into v4 please. Sorry the tokens code has changed and it will need some editing in the re-roll.
- Status changed to Needs review
over 1 year ago 11:02am 11 October 2023 - last update
over 1 year ago 34 pass, 6 fail - ๐ฎ๐ณIndia mrinalini9 New Delhi
Rerolled patch #7 for the
4.x-dev
branch, please review it.Thanks!
The last submitted patch, 9: 3317849-9.patch, failed testing. View results โ
- First commit to issue fork.
- Merge request !82Issue #3317849: Multilingual tokens are not translated โ (Merged) created by davps
MP 82 contains a test covering the problem and changes to fix it.
I would like to highlight some important points:
- the fix only solves the problem with the newsletter name
- it is not clear how relevant the URL token is. I updated the code so that there are no errors and left a todo. We can discuss what to do with this
- the problem with respecting the language in links remains and it is general, as it applies to other links as well. I will create a new task and would suggest fixing this in the new task.
- ๐ฌ๐งUnited Kingdom adamps
Thanks. As I put in a comment in the MR - I feel we could just delete the url token.
@adamps, ready to review with final fixes:
- fixed problem with newsletter name translation
- fixed problem with respecting subscriber's language in action urls
-
adamps โ
committed 91c48495 on 4.x authored by
davps โ
Issue #3317849 by davps, joel_osc, vlad.dancer, mrinalini9, adamps:...
-
adamps โ
committed 91c48495 on 4.x authored by
davps โ
Automatically closed - issue fixed for 2 weeks with no activity.