- ๐ฌ๐งUnited Kingdom adamps
Thanks for the report and patch. I'm the only active maintainer and I don't use multi-lingual๐ - it would be great if someone else could test.
The patch looks correct to me, it could be tidied up a little:
- Instead of
\Drupal::service('language_manager');
use\Drupal::languageManager()
- Use the
$language_manager
variable within the loop - Can the translation really be missing a name? Even if yes, can simplify the code with ?? operator.
- The 'sanitize' option was removed in Drupal 8๐ - as we are changing the code, let's delete that part
- Instead of
- Status changed to Needs review
about 1 year ago 10:39pm 10 October 2023 - last update
about 1 year ago 59 pass - ๐บ๐ฆUkraine vlad.dancer Kyiv
Here is patch with addressed comments from #6
- Status changed to Needs work
about 1 year ago 10:34am 11 October 2023 - ๐ฌ๐งUnited Kingdom adamps
Great thanks. All patches now need to go into v4 please. Sorry the tokens code has changed and it will need some editing in the re-roll.
- Status changed to Needs review
about 1 year ago 11:02am 11 October 2023 - last update
about 1 year ago 34 pass, 6 fail - ๐ฎ๐ณIndia mrinalini9 New Delhi
Rerolled patch #7 for the
4.x-dev
branch, please review it.Thanks!
The last submitted patch, 9: 3317849-9.patch, failed testing. View results โ
- First commit to issue fork.