Multilingual tokens are not translated

Thanks for the report and patch. I'm the only active maintainer and I don't use multi-lingual😃 - it would be great if someone else could test.

The patch looks correct to me, it could be tidied up a little:

1. Instead of \Drupal::service('language_manager'); use \Drupal::languageManager()
2. Use the $language_manager variable within the loop
3. Can the translation really be missing a name? Even if yes, can simplify the code with ?? operator.
4. The 'sanitize' option was removed in Drupal 8😃 - as we are changing the code, let's delete that part

Here is patch with addressed comments from #6

Great thanks. All patches now need to go into v4 please. Sorry the tokens code has changed and it will need some editing in the re-roll.

Rerolled patch #7 for the 4.x-dev branch, please review it.

Thanks!

The last submitted patch, 9: 3317849-9.patch, failed testing. View results →

MP 82 contains a test covering the problem and changes to fix it.

I would like to highlight some important points:

1. the fix only solves the problem with the newsletter name
2. it is not clear how relevant the URL token is. I updated the code so that there are no errors and left a todo. We can discuss what to do with this
3. the problem with respecting the language in links remains and it is general, as it applies to other links as well. I will create a new task and would suggest fixing this in the new task.

Thanks. As I put in a comment in the MR - I feel we could just delete the url token.

@adamps, ready to review with final fixes:

• fixed problem with newsletter name translation
• fixed problem with respecting subscriber's language in action urls

Great thanks everyone

Automatically closed - issue fixed for 2 weeks with no activity.

Hi, I created this bug https://www.drupal.org/project/simplenews/issues/3534572 🐛 Unsubscribe link uses outdated 'langcode' option in Url::fromRoute(), resulting in incorrect language in generated URL Active , but I noticed later that this is already fixed. However, it hasn't been merged.
Is there a plan for the next release?