undefined - Contrib.social

🇺🇦Ukraine vlad.dancer Kyiv

Just a small note.
Now, default value for the "Allow Embedding" setting is set to false. Anyway after module installation there is no default configuration that was imported on install, so setting this setting to false is quite expected.

🐛 | @font-your-face | WSOD on edit custom font

🇺🇦Ukraine vlad.dancer Kyiv

The fix works and resolve this issue.

📌 | Migrate Spreadsheet | Support PHPSpreadsheet ^2.0

🇺🇦Ukraine vlad.dancer Kyiv

Nice idea! Changed.

📌 | Migrate Spreadsheet | Support PHPSpreadsheet ^2.0

🇺🇦Ukraine vlad.dancer Kyiv

📌 | Migrate Spreadsheet | Support PHPSpreadsheet ^2.0

🇺🇦Ukraine vlad.dancer Kyiv

📌 | Migrate Spreadsheet | Support PHPSpreadsheet ^2.0

🇺🇦Ukraine vlad.dancer Kyiv

For the moment I used this workaround: composer require phpoffice/phpspreadsheet:'2.2.2 as 1.29.1'

📌 | Migrate Spreadsheet | Support PHPSpreadsheet ^2.0

✨ | Migrate Spreadsheet | Allow to use the spreadsheet iterator as a migrate_plus data parser

🇺🇦Ukraine vlad.dancer Kyiv

vlad.dancer → created an issue.

🐛 | IntelligenceBank DAM Connector | PHP warnings when using CKEditor plugin to access DAM through media library

🇺🇦Ukraine vlad.dancer Kyiv

Thank you @duaelfr and @Matthijs for this plugin. We've used for a couple of years. It worked great.
But recently migrated to Drupal 10 and also changed some data import logic.
We needed "id-less" data import. Well, actually migrate can't do that. But we decided to use
"row_index_column" field, provided by this module, and xls file_name as ids.

Here is our migration config:

source:
  plugin: custom_source_extends_url_source
  data_fetcher_plugin: file
  data_parser_plugin: custom_data_parser_extends_migrate_spreadsheet
  track_changes: true
  worksheet: 'Sheet1'
  origin: A2
  header_row: 1
  item_selector: null
  // Filled up on runtime
  urls: []
  columns: []
  fields: []

  # Actual ids for migrate source plugin will be next:
  # - file_name
  # - spreadsheet_row_index
  ids:
    spreadsheet_row_index:
      type: string
  row_index_column: 'spreadsheet_row_index'

And then we faced a number of issues with data parser plugin.
I'm not sure the roots of them, maybe updated migrate/migrate_plus/drupal apis.

But here are how we ended up using data parser plugin and fixed issues.

@claudiu.cristea was right about that file in openSourceUrl() can come not only from remote, but from local fs.

Here how delt with it:

protected function openSourceUrl($url): bool {
    $fetcher = $this->getDataFetcherPlugin();

    if ($fetcher->getPluginId() === 'file') {
      $this->configuration['file'] = $url;
    }
    else {
      // Why we want to read file two times?
      /** @var \GuzzleHttp\Psr7\Response $response */
      $response = $this->getDataFetcherPlugin()->getResponse($url);

      preg_match('/filename="(.*?)"/', $response->getHeader('Content-Disposition')[0] ?? '', $matches);
      $this->configuration['file'] = $this->fileSystem->saveData($response->getBody(), 'temporary://' . $matches[1], FileSystemInterface::EXISTS_RENAME);
    }

    $this->initializeIterator();
    return TRUE;
  }

Next thing. In our case checking for an empty current item in valid() was not enought. We got infinite loop.
So ended up with checking row_index_column and rows count:

public function valid(): bool {
    $currentItem = $this->currentItem;
    if (!$currentItem) {
      return FALSE;
    }
    if (!parent::valid()) {
      return FALSE;
    }

    // Check iterator for current/max index.
    // Fix issue with lost last record.
    $rowIndexCol = $this->configuration['row_index_column'] ?? NULL;
    if ($rowIndexCol) {
      $index = $currentItem[$rowIndexCol];
      $max = $this->spreadsheetIterator->getRowsCount();

      if ($index <= $max) {
        return TRUE;
      }
    }
    // Fallback to default check, which doesn't work for us,
    // but should work for others if they use "row_index_column" feature.
    else {
      return $this->spreadsheetIterator->valid();
    }

    return FALSE;
  }

BTW: there is also php notice for undefined row_index_column array key in SpreadsheetIterator class but I'll report this issue separately and link it here.

🐛 | IntelligenceBank DAM Connector | PHP warnings when using CKEditor plugin to access DAM through media library

🇺🇦Ukraine vlad.dancer Kyiv

Ok, looks like there is no need to store an empty data inside $widget_context['ib_dam_media']:

"field" => array:3 [
    "name" => null
    "entity_type_id" => null
    "entity_bundle_id" => null
  ]

when modal has been opened from CKEditor.

For now I'm accepting MR and put into my todo list optimising this case.

Thank for heads up!

🐛 | IntelligenceBank DAM Connector | PHP warnings when using CKEditor plugin to access DAM through media library

🇺🇦Ukraine vlad.dancer Kyiv

Oh, I just realized that tugboat deployed Drupal with MR applied there. Ok, I need to test it on gitpod, without the MR.

🇺🇦Ukraine vlad.dancer Kyiv

@joegraduate I can't reproduce it with steps defined in issue's description. Check it here https://mr18-ofex2zwrcgdavguzjeqiezzieztdtign.tugboatqa.com/node/1 . No errors found in db log https://mr18-ofex2zwrcgdavguzjeqiezzieztdtign.tugboatqa.com/admin/report...

What additional steps did you do to get such errors? Which Drupal, module, php versions are you using? Have you configured settings here admin/config/services/ib_dam/media ?

BTW: "Select the downloaded image in the Media library" step is not necessary because after selecting asset in DAM modal it will be automatically downloaded and preselected in media modal.

🐛 | Computed Field Plugin | Error message on Drupal 10.2

🇺🇦Ukraine vlad.dancer Kyiv

🐛 | Select 2 | Broken tests on Drupal 10.3+

🇺🇦Ukraine vlad.dancer Kyiv

vlad.dancer → created an issue.

🐛 | Facets | Facets with AJAX not working in most of situations

🇺🇦Ukraine vlad.dancer Kyiv

I came here from 🐛 [1.15.0] bug, "Session has not been set" error thrown by select2_facets Needs review where ajax doesn't work after updating drupal core to 10.3+. While worked on solution I found code places in facets module where Request::create beeing used too: facets/src/Controller/FacetBlockAjaxController.php. So there is high chance that ajax facets won't wotrk too on drupal 10.3+. Probably because of changes in core/modules/views/src/ViewExecutable.php
It looks like @joao.ramos.costa and @svenseeberg have already expirienced this bug and can confirm it. Adding session is requred now (when dealing with views?):

    $new_request = Request::create($path);
    $new_request->setSession($request->getSession());

🐛 | Select 2 | [1.15.0] bug, "Session has not been set" error thrown by select2_facets

🇺🇦Ukraine vlad.dancer Kyiv

🐛 | Select 2 | [1.15.0] bug, "Session has not been set" error thrown by select2_facets

✨ | PhotoSwipe - Responsive JavaScript Modal Image Gallery | [5.x] Make Photoswipe work with any ContentEntity entity type

🇺🇦Ukraine vlad.dancer Kyiv

vlad.dancer → created an issue.

✨ | PhotoSwipe - Responsive JavaScript Modal Image Gallery | Dynamic caption: How to use a dedicated caption field on a media entity?

🇺🇦Ukraine vlad.dancer Kyiv

FYI: there is no Photoswipe Dynamic Plugin field formatter settings inside views field settings (when you select show fields and use Photoswipe as field formatter). For that you need to apply this patch 🐛 Formatter third party settings missing from Views UI Needs work

🇺🇦Ukraine vlad.dancer Kyiv

🌱 | Field Group Layout | [META] Stable release 2.x

🇺🇦Ukraine vlad.dancer Kyiv

🐛 | Field Group Layout | Failed to open stream