[5.x] Separate image and entity_reference formatters

I've separated mage and entity_reference formatters. Please check it.

Hi @Anybody just to clarify. What we need is to implement 4 formatters - 2 for image (Responsive and Not) 2 for entity_reference (Responsive and Not) Is that correct?

@dinazaur:

Hi @Anybody just to clarify. What we need is to implement 4 formatters - 2 for image (Responsive and Not) 2 for entity_reference (Responsive and Not) Is that correct?

Yes that's right. Of course we should try to not duplicate code where possible, for example by using inheritance and base / abstract classes.

I've separated mage and entity_reference formatters. Please check it.

Hey @bobi-mel, thanks for your work! I reviewed it, looks great! I've worked on #3455963 on top of your code.

Thank you all very much! To ensure this works stable, we should have tests for the new features like for the existing old ones.
This module is widely used and broke too often in the past. We shouldn't risk that. Thanks!

We have separate tests for the Image and the Media Reference. While working on the issue I fixed the test for the Media Reference after splitting the formatted

I guess they are enough

Branch is 19 commits behind and needs to get rebased.

Are we sure we still want this? If still relevant, we should target 6.x.

Yeah maybe one day... if anyone does it. We won't implement this ourselves.

We shouldn't support Drupal 6 @anybody :P

We also shouldn't create a 6.x release yet. Otherwise, we will be getting into the cherry-pick fiasco again.