- Issue created by @biarr
- Status changed to Postponed: needs info
almost 2 years ago 3:02pm 13 March 2023 - 🇩🇪Germany geek-merlin Freiburg, Germany
Thanks for reporting this. Did you look for existing issues? DOes the patch in the related issue fix that?
- 🇺🇿Uzbekistan biarr
Dear geek-merlin, thank you for your prompt reply. I applied the mentioned patch but it didn't solve the problem.
- Status changed to Active
almost 2 years ago 10:06pm 14 March 2023 - 🇩🇪Germany geek-merlin Freiburg, Germany
OK so likely the upstream render array ran away and this needs debugging.
- 🇮🇳India omkar-pd
Installed the module on Drupal 10. Was able to reproduce the issue. It seems that value
$element['#datetimehideseconds']['hide']
Is getting Null even if the hide seconds field is checked in the widget. So the code insideif (!empty($element['#datetimehideseconds']['hide']))
is not excuted. - 🇮🇳India omkar-pd
After some RnD. I found out that
hook_field_widget_form_alter
is removed in Drupal 10. Check out the below link for change records. - Status changed to Needs review
almost 2 years ago 9:43am 15 March 2023 - 🇩🇪Germany geek-merlin Freiburg, Germany
This looks convincing! Does it fix the issue for you?
If you add a MR, it will be committed sooner ;-). - @omkar-pd opened merge request.
- 🇮🇳India omkar-pd
Yes @geek-merlin, it fixes the issue for me. Raised an MR.
-
geek-merlin →
committed e0c08ef5 on 8.x-1.x authored by
omkar-pd →
Issue #3347617 by omkar-pd, biarr, geek-merlin: Doesn't hide seconds on...
-
geek-merlin →
committed e0c08ef5 on 8.x-1.x authored by
omkar-pd →
- Status changed to Fixed
almost 2 years ago 5:19pm 15 March 2023 - 🇩🇪Germany geek-merlin Freiburg, Germany
OK committed this. Thanks a lot!
We really need a test so this won't break again. So if you know someone... ;-)
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 8:08pm 9 November 2023 - 🇨🇦Canada leducdubleuet Chicoutimi QC
I know this has been committed already on dev for a while but we would need a new release please for Drupal 10 now that Drupal 9 is EOL.
Thank you!