Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 3 years ago
Updated 13 April 2023, over 2 years ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @earthday47 opened merge request.
  • Comment over 2 years ago →
    🇺🇸United States earthday47 New York

    Created fork with the automated fixes, added core_version_requirement.

  • Comment over 2 years ago →
    🇦🇺Australia marc.groth

    Thanks @earthday47. I was able to use your PR to create a patch which I applied to the module... Which makes it D10 compatible.

    I have attached the patch in case it is useful for somebody.

  • Comment over 2 years ago →
    🇦🇺Australia marc.groth

    I just noticed that a line break is added to the .info.yml file as part of this patch which actually breaks when Drupal metadata is added to the file (because the line break should not be there according to the original file). I have attached an updated patch that takes this into account.

    The original .info.yml file will need to updated to include the line break if needed (which is suggested to keep it consistent with Drupal coding standards).

  • Comment about 2 years ago →
    🇫🇷France devil2005

    Hi,

    Is there any release of a stable version for D10 please ?

    thanks

  • Comment about 2 years ago →
    🇺🇸United States amanire

    The patch in #7 applied to 8.x-2.0 for me. Thank you!

  • Comment almost 2 years ago →
    🇺🇸United States caspervoogt

    #7 worked for me

  • Status changed to RTBC almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States SocialNicheGuru

    Works for me too

  • Comment over 1 year ago →
    🇺🇦Ukraine vlad.dancer Kyiv

    Hey @devil2005 you can require d10 compatible module version in the next way:

    composer remove drupal/ckeditor_uploadimage

    Then edit composer.json:

    {
      "type": "package",
      "package": {
        "name": "drupal/ckeditor_uploadimage",
        "type": "drupal-module",
        "version": "dev-2.x",
        "source": {
          "type": "git",
          "url": "https://git.drupalcode.org/issue/ckeditor_uploadimage-3296782.git",
          "reference": "f87155bc4d671a6763b93c49bd0bececcd37d763"
        }
      }
    },

    And place the above right before:

    {
      "type": "composer",
      "url": "https://packages.drupal.org/8"
    },
    {
      "type": "composer",
      "url": "https://asset-packagist.org"
    },

    Then run composer require drupal/ckeditor_uploadimage:dev-2.x
    The last step you might need to run two times.

  • Comment 2 months ago →
    🇧🇪Belgium p-neyens

    After upgrading a D9 to D10 site i get the following warning

    Undefined array key "max_size" when using the format "
    "

    I created a new ticket 🐛 Undefined array key "max_size" when using the format "flexible_html" Active for that

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024