- Issue created by @tjhellmann
- πΊπΈUnited States smustgrave
Seems like something that could be a configuration in the form
- Status changed to RTBC
about 1 year ago 7:25pm 4 November 2023 - πΊπΈUnited States chucksimply
Yup, after the upgrade to 4.0, all image-only fieldsets don't show. Patch works great. Lets push!
- π¬π§United Kingdom alx_benjamin
I have a slightly different issue.
$child->content is not a string, in my case, but a Drupal\Core\Render\Markup.
Any advice? :(Thank you
- Status changed to Needs work
about 1 year ago 4:01pm 9 November 2023 - πΊπΈUnited States smustgrave
Think this should be a configuration form so you can choose tags, that may solve it.
- π¬π§United Kingdom alx_benjamin
Sorry @smustgrave,
I've updated my comment, It is a different issue.
Please see above.Thank you.
- π¬π§United Kingdom alx_benjamin
Found the culprit,
the ['#markup' => "html goes here'] had to be wrapped in render() function.
- Status changed to RTBC
12 months ago 4:22pm 11 December 2023 - ππΊHungary szato
I'm using module v 4.0.0 with Drupal 10.1.6. Have a fieldset (div wrapper) with only image field - image not rendered.
Patch solved the issue.I'm moving to RTBC.
- Status changed to Needs work
12 months ago 4:37pm 11 December 2023 - πΊπΈUnited States smustgrave
Since there could be other tags, thing this should be a configuration form to allow others tags if needed.
- πΊπΈUnited States chucksimply
I'm using the module Views Entity Form Fields β to display form fields in a view. Any form fields in a fieldset (on their own) don't display (same behavior as img).
@smustgrave is right, there needs to be support for more tags.
- ππΊHungary szato
This bug is connected to: #3369756 Empty fields are not hidden β¨ Empty fields are not hidden Fixed
@smustgrave
I don't think adding a configuration is the right way. It's about checking whether the rendered output of the fieldset is empty or not. We should fix/refactor code changes committed in #3369756 - πΊπΈUnited States bcobin
Holy cow - I spent the day trying to figure out why my images weren't displaying; I'm rebuilding from a dev site and in creating the identical view, one view displayed images while the other didn't. I was going nuts. Then I found this post. Patch fixed it and, sure enough, I see that the dev site was running 8.34.
I think this should be more heavily flagged, though, if possible - those doing upgrades on live sites could easily have all their images disappear without having a clue as to what did it. Just sayin'.
Thanks for the module... and for the fix... Whew!
- πΊπ¦Ukraine vlad.dancer Kyiv
Another quick workaround add hidden span tag
<span class="hidden"> </span>
. - π³π±Netherlands interactivex
The patch didn't work for version 4.0.1 so I created a patch for that version. I can confirm now the images do work again.
- π΅πͺPeru alyaj2a
In my case, I make this patch, It's function for me!