Support for quality and lang query parameters

Here is a quick fix that allows using just those mentioned parameters - "lang" and "quality".
Obviously, this could be made much better, but like mentioned, this is a quick fix :)

Ok, another try.
The first patch was a failure as it would not allow using DreamBroker videos without lang and quality parameters. That should be fixed now. In addition, I tried to fix deprecated/broken tests. So let's see how this attempt turns out (fingers crossed).

Thank you for the contribution! Here are a couple of notes on the patch.

+++ b/src/Plugin/Field/FieldFormatter/DreambrokerEmbedFormatter.php
@@ -53,22 +53,34 @@ class DreambrokerEmbedFormatter extends FormatterBase {
+        $channelid = current($matches['id']['channelid']);

I would like to see variable names conforming better to coding standards, e.g. $channel_id.

+++ b/src/Plugin/Field/FieldFormatter/DreambrokerEmbedFormatter.php
@@ -53,22 +53,34 @@ class DreambrokerEmbedFormatter extends FormatterBase {
+        // Use preg_match_all() to match multiple times (for URL params)

Coding standards mandate ending all inline comments with a full stop.

Updated patch #3 by addressing #4, please review it.

Thanks!

Thanks @mrinalini9! The patch in #5 seems to work.

add parameters to the url with quality=1080p&lang=sv and it worked well.

Moing it to RTBC.

Sorry about mixing things up a bit, but I just noticed that the patch in this issue also fixes a lot of Drupal 10 compatibility issues. Because this project doesn't have the Automated D10 patch, I guess we could use this issue to come up with a simple D10 support at the same time?

I checked the patch from #5 with Upgrade Status module and only thing missing from it is the version number. So here is another patch that should add it as well. After that this could be used for Drupal 10 upgrade too?

> -core_version_requirement: ^8.8 || ^9
> +core_version_requirement: ^8.8 || ^9 || ^10

I am choosing a different path with the versions. I created a different issue for pure D10 support (see https://git.drupalcode.org/project/media_entity_dreambroker/-/merge_requ... and #3395467 📌 Support Drupal 10 Active ). I will publish that version as 2.0.0 and will add a 2.1.x branch where I'll incorporate these changes. Thanks again for the efforts!

Updating status and base version to rerun some testing and to create a MR.

Uploading new patch which is based on 2.1.x. Also providing interdiff, even if that now contains changes already present in the published version 2.0.0 since they weren't yet present in the patches here.

Please @hartsak if you are able, test the issue fork with a D10 installation to see whether my changes are valid.

Hello @kekkis!
I finally had time and an opportunity to test the issue fork in my D10 (10.1.5) project. Works as expected: D10 compatible, both quality and lang parameters work. The videos also work without the additional parameters.

Thank you for your efforts in maintaining this!

Thank you for the contributions here, I assigned credit to everyone involved. Sorry that I didn't think to add this comment in the same status update.

Automatically closed - issue fixed for 2 weeks with no activity.