If the session language provider is enabled and page cache is enabled (and
#815526: Session language switcher prevents pages from being cached →
is fixed), we can have duplicate page cache entries for the same content because the language switcher block appends the language query string parameter even for the default language link. If no language parameter is found we may fall back to the default language and thus having the same content for, say, http://example.org/ and http://example.org/?language=en.
Fix the issue by forbidding query string language parameters when page cache is enabled and the parameter value matches the default language.
Convert to an MR
Add test
Needs work
11.0 🔥
It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Re-titling since the title makes this seem like a page cache bug, it's more about URL cleanliness.
Converted patch #66 to an MR (!9533). Unsure where to start on tests, though i will be following
Fixed pipeline failure issues in the MR, please review it.
Thanks!
previously tagged for tests which still appear to be needed.