- Issue created by @bgilhome
- Assigned to jay jangid
- Issue was unassigned.
- 🇮🇳India jay jangid Jaipur
Hi @bgilhome thanks for creating the patch. I have applied your patch.
The patch was applied successfully.
Seems working according to the above Proposed resolution.And Can you please add more details on the issue and provide steps to reproduce it?
this will be helpful for replicating the issue so kindly write the "Steps to reproduce".Thank you.
-
matthieuscarset →
committed 1d426266 on 1.0.x
feat: Remove component if field hidden #3372169
-
matthieuscarset →
committed 1d426266 on 1.0.x
- Status changed to Fixed
about 1 year ago 7:53pm 9 October 2023 Committed! Will be release soon.
Thanks a lot for reporting this issue and for the code provided.
- Status changed to Needs work
about 1 year ago 11:09pm 9 October 2023 - 🇹🇳Tunisia adel-by
Hello,
It should be
$settings = $custom_options + $default_settings;
not
$settings = $default_settings + $custom_options;
or else all fields get added to the "hidden" region (the default value) even if explicitly set to "content"
- Status changed to Needs review
about 1 year ago 10:50am 10 October 2023 - 🇮🇳India mrinalini9 New Delhi
Added patch for the changes mentioned in #6, please review it.
Thanks!
-
matthieuscarset →
committed 46f654ea on 1.0.x
fix: Wrong order in default settings #3372169
-
matthieuscarset →
committed 46f654ea on 1.0.x
- Status changed to Fixed
about 1 year ago 7:02pm 12 October 2023 oups... thank you very much for spotting this error.
Fixed on
1.0.7
Automatically closed - issue fixed for 2 weeks with no activity.