- Issue created by @yashmalviya
- Issue was unassigned.
- ๐ฎ๐ณIndia yashmalviya
I have fixed the issues mentioned above. Please review
- Assigned to mohd sahzad
- ๐ฎ๐ณIndia mohd sahzad
I have fixed this issue : Fix Coding Standard Issues. please review patche3
- Issue was unassigned.
- ๐ฎ๐ณIndia sarwan_verma
sarwan โ made their first commit to this issueโs fork.
- @sarwan opened merge request.
- Status changed to Needs review
about 1 year ago 8:33am 29 September 2023 - Status changed to Needs work
about 1 year ago 9:40am 6 October 2023 - ๐ฎ๐ณIndia mrinalini9 New Delhi
Hi,
I have reviewed patch #4, it applied cleanly but has some extra file changes i.e., in the .module file. Please revert this change as it's not required.
Also, still getting the below errors after applying the patch:FILE: /entity_browser_enhanced/enhancers/multiselect/js/entity_browser_enhanced.multiselect.js ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 8 ERRORS AFFECTING 8 LINES ------------------------------------------------------------------------------------------------------------------------------------------------ 31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 53 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 55 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 75 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 77 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------
Please fix these errors as well.
Thanks & Regards,
Mrinalini - ๐ฎ๐ณIndia Gautam_105@
Gautam_105@ โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 10:04am 6 October 2023 - ๐ฎ๐ณIndia Gautam_105@
Hi mrinalini9,
i have fixed all phpch issue and created MR for the same . Please review and see screenshot as well.