Fix Coding Standard Issues

Created on 23 July 2023, over 1 year ago
Updated 6 October 2023, about 1 year ago

Problem/Motivation

FILE: /var/www/html/drupal9_test/code/modules/contrib/entity_browser_enhanced/entity_browser_enhanced.enhancers.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9_test/code/modules/contrib/entity_browser_enhanced/entity_browser_enhanced.info.yml
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9_test/code/modules/contrib/entity_browser_enhanced/.gitlab/issue_templates/default.md
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
39 | ERROR | [x] Expected 1 newline at end of file; 0 found

๐Ÿ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia yashmalviya

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @yashmalviya
  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia yashmalviya

    I have fixed the issues mentioned above. Please review

  • Assigned to mohd sahzad
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia mohd sahzad

    I have fixed this issue : Fix Coding Standard Issues. please review patche3

  • Issue was unassigned.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sarwan_verma

    sarwan โ†’ made their first commit to this issueโ€™s fork.

  • @sarwan opened merge request.
  • Status changed to Needs review about 1 year ago
  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia mrinalini9 New Delhi

    Hi,

    I have reviewed patch #4, it applied cleanly but has some extra file changes i.e., in the .module file. Please revert this change as it's not required.
    Also, still getting the below errors after applying the patch:

    FILE: /entity_browser_enhanced/enhancers/multiselect/js/entity_browser_enhanced.multiselect.js
    ------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 8 ERRORS AFFECTING 8 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------------
     31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
     35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
     42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
     46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
     53 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
     55 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
     75 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
     77 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    ------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------------------------------------------
    

    Please fix these errors as well.

    Thanks & Regards,
    Mrinalini

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Gautam_105@

    Gautam_105@ โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Needs review about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Gautam_105@

    Hi mrinalini9,
    i have fixed all phpch issue and created MR for the same . Please review and see screenshot as well.

Production build 0.71.5 2024