- Issue created by @Murz
- Merge request !8883Issue #3463251: Provide an interface for Drupal HTTP ClientFactory service β (Open) created by Murz
- Status changed to Needs review
about 2 months ago 6:33am 23 July 2024 - π¦π²Armenia Murz Yerevan, Armenia
I made an MR https://git.drupalcode.org/project/drupal/-/merge_requests/8883 with implementing the
Drupal\Core\Http\ClientFactoryInterface
- please review. - π³πΏNew Zealand quietone New Zealand
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
It is my understanding the the 'Needs Review Queue Initiative' tag is added after the issue has been reviewed by that initiative, so they can monitor the activity on reviewed issue. The definition β of this special tag supports my thinking. Am I wrong?
- Status changed to Needs work
about 2 months ago 2:35pm 23 July 2024 - πΊπΈUnited States smustgrave
Ignored error pattern #^Call to deprecated method getConfig\(\) of class GuzzleHttp\\Client\: Client\:\:getConfig will be removed in guzzlehttp/guzzle\:8\.0\.$# in path /builds/issue/drupal-3463251/core/tests/Drupal/Tests/Core/Http/ClientFactoryTest.php was not matched in reported errors. 58 Call to deprecated method getConfig() of interface GuzzleHttp\ClientInterface: ClientInterface::getConfig will be removed in guzzlehttp/guzzle:8.0. πͺͺ method.deprecated ------ -----------------------------
Appears to have phpstan issues
@quietone that's a good question not sure we ever decided on that.
- Status changed to Needs review
about 2 months ago 5:34am 24 July 2024 - π¦π²Armenia Murz Yerevan, Armenia
> Appears to have phpstan issues
Yes, but they are not related to the changes at all. And I have no idea about how to fix this error, only remove the test. Here is an issue about this: https://github.com/guzzle/guzzle/issues/3114
- Status changed to Needs work
about 1 month ago 1:44pm 6 August 2024 - πΊπΈUnited States smustgrave
Would first try rebasing as current MR is 67 commits behind.
Then can see if it passes but can't mark it with failing checks.