Increase link_url field maxlength

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

This could use test coverage for this change.

Tagging for subsystem review just in case they had any thought.

quietone → credited daniel.kushner → .

Closed older issue as duplicate, adding credit ✨ Increase character length for custom url on views Needs work

Created MR for the 11.x branch, please review it.

Thanks!

Was previously tagged for tests which are still needed.

Please read the tags and comments before putting into review to not delay the issue.

I have added test coverage for this functionality and thoroughly tested it. The pipeline has also passed successfully. I am now moving this to the 'Needs Review' stage.
Please review.

Comment on MR.

oily → changed the visibility of the branch 3258434-increase-linkurl-field to hidden.

Not sure if this needs a change record..

Not 100% but leaning on yes maybe?

There is now a failing test in place. An error message seems to be getting generated when a 'long' url is used.

So it seems that the test coverage is sound. But the fix needs more work. Manual testing should reveal the wording of the error that is being generated.

@smustgrave Will compute 'yes maybe' == 'yes' : )

Created a change record.

The test is failing because there are in fact classes in the page source named 'messages' which have nothing to do with errors.

But the increased maxlength property does not prevent link text > 128 characters from being chopped off at 128. I also tried adding a size property and setting that to > 128 characters. But that has no effect on the textbox either.

Some fields in Core override the default maxlength attribute up to 1024 characters. There is no reason to not do so in this case.

Yes, but these fields are using a different field widget. I think that a new field widget needs to be created and associated with the core textfield. The link-url form field would then use textfield and the new widget.