- Issue created by @himanshu_jhaloya
- @himanshu_jhaloya opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:29am 9 May 2023 - Status changed to RTBC
over 1 year ago 10:08am 9 May 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi himanshu_jhaloya
I applied your MR to the โPantheon Secretsโ module and confirmed that the phpcs mentioned are resolved and the remaining warnings is for the maintainer if it needs to be fixed. Please see the screenshots attached.
For your review.
Thank you. - Status changed to Needs work
over 1 year ago 11:44am 9 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
``` - terminus drush <site>.<env> -- en -y pantheon_secrets sendgrid_api sendgrid_mailer + terminus drush <site>.<env> -- en -y pantheon_secrets + sendgrid_api sendgrid_mailer ```
Commands shown in .md files must be formatted to make clear it is the same command, not two different commands.
The report shows also warnings/errors for the pantheon_secrets.info.yml file, but the MR does not change that file.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:53am 11 May 2023 - Status changed to Needs work
over 1 year ago 7:58am 11 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
``` - terminus secret:set <site> --scope=web --type=runtime <secret_name> <secret_value> + terminus secret:set <site> --scope=web --type=runtime + <secret_name> <secret_value> ```
Commands shown in .md files must be formatted to make clear it is the same command, not two different commands.
- Status changed to Needs review
over 1 year ago 8:37am 11 May 2023 - ๐ฎ๐ณIndia imustakim Ahmedabad
Fixed the command in .md file, it shows line exceed error, assuming this can be ignored as the command line shoud be a one line.
Patch updated, please review. - Status changed to Active
about 1 year ago 2:40pm 13 October 2023 - Status changed to Needs review
about 1 year ago 3:05pm 13 October 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Since there is a patch to review, the correct status is Needs review.
- Status changed to Needs work
about 1 year ago 6:54am 16 October 2023 - ๐ฎ๐ณIndia mrinalini9 New Delhi
Hi,
I have reviewed patch #10, it applied, but threw some
trailing whitespace
issues at the time of applying the patch:3359008-10.patch:30: trailing whitespace. 1) Add a new key through the Key module UI. Select Pantheon Secret as 3359008-10.patch:32: trailing whitespace. 1) Go to /admin/config/system/keys/pantheon and click on the "Sync Keys" 3359008-10.patch:34: trailing whitespace. 1) Use the provided drush command to sync all of your secrets 3359008-10.patch:48: trailing whitespace. 1) Make sure you have access to a Drupal >= 9.4 site running PHP >= 8.0 3359008-10.patch:56: trailing whitespace. 1) Install the required modules in your Drupal site and push the warning: squelched 9 whitespace errors warning: 14 lines add whitespace errors.
Also, it fixed all the phpcs issues as reported, except this one:
FILE: /pantheon_secrets/README.md ----------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------- 48 | WARNING | Line exceeds 80 characters; contains 86 characters -----------------------------------------------------------------------------------
Please fix all these issues.
Thanks & Regards,
Mrinalini - Assigned to Gautam_105@
- Status changed to Needs review
about 1 year ago 7:11am 16 October 2023 - ๐ฎ๐ณIndia Gautam_105@
@mrinalini9,
i have fixed this and created MR for the same. Please review and see screenshot as well - Issue was unassigned.
- Status changed to Needs work
about 1 year ago 3:15pm 16 October 2023 - Status changed to Closed: works as designed
about 1 year ago 3:24pm 7 November 2023 - ๐จ๐ทCosta Rica kporras07
Thanks for your contributions.
Although I love coding standard; this is only docs files and I don't see a lot of value in following standards in MD files where I prefer readability over standards.
I'm going to close this issue as works as designed.