- Merge request !2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation → (Open) created by rlmumford
- 🇺🇸United States smustgrave
Seems there are still some open questions to answer before review.
#39 and #41 should be answered (added to remaining tasks)
- 🇷🇺Russia Chi
Faced this issue with "single-table" entity type. Entity query joined base table to itself which caused bad performance. Patch #16 works well on Drupal 10.0.
- 🇷🇺Russia Chi
Patch #16 works well on Drupal 10.0.
Actually it does not. EFQ with entity references produces wrong SQL join. See comment #30.
- 🇳🇱Netherlands spadxiii
We have been using the mr in #37 for a while, but there are some issues with it: when using multiple conditions on the same column in an entity-query, the same table is joined several times.
I've fixed this with another if-statement in the patch that checks if the table is already joined (with the same type).
@spadxiii Please make the change to the merge request, rather than submitting a patch.
- 🇳🇱Netherlands spadxiii
I seem to have attached the wrong patch. Here's the correct one, that works.
- 🇳🇱Netherlands spadxiii
@solideogloria the mr is quite old and needs to be rebased :\
and when I push, I get an error that: remote: You are not allowed to push code to this project.
So I cannot update the mr. You have to click the "Get Push Access" button at the top of this page.
- First commit to issue fork.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 2875033-optimize-joins-and to hidden.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 2875033-optimize-joins-and to hidden.
- 🇮🇳India mrinalini9 New Delhi
Hi,
I have tried to create MR for the changes mentioned in patch #48 but was unable to do so because the MR points to branch 9.5.x instead of 11.x. Also, I have tried to create a new branch from 11.x but getting the below error:
Thanks & Regards,
Mrinalini @mrinalini9 This should be helpful for you: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →
- First commit to issue fork.
- 🇯🇵Japan ptmkenny
To run the tests, I created an MR of patch #48.
- 🇫🇷France Nixou Toulon
Thanks for this !
Attach is the patch from #48 (2875033-46.patch) rerolled for Drupal 10.3.x and 10.4.x