Illegal choice in grouped exposed filters with enabled option remember (ListField, BooleanOperator - Views filter handlers )

The issue is still present for grouped filters on D9.5.9. So, here is a reroll of the patch in #36.

I can confirm that this is still an issue as of D10.1.7. Patch #44 applies cleanly and resolves the issue for us.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

It does not seem to work for role filter grouping? With 9.5 patch #36 #44 is applied but the error as described above remains, at least in our case. Maybe someone can take another look at this case.

Standard procedure is to fix this on the 11.x branch and then backport to other release branches.

ivnish → changed the visibility of the branch 10.0.x to hidden.

ivnish → changed the visibility of the branch 11.x to hidden.

ivnish → changed the visibility of the branch 2877061-illegal-choice-remembered-group-filters to hidden.

I rerolled issue fork to 11.x

I also use this patch in my project and it fixed bug from issue title

Still appears to need test coverage

Also can a proposed solution be added to the issue summary please

Thanks!

@smustgrave

Still appears to need test coverage

I added a test

Also can a proposed solution be added to the issue summary please

I don't know how to name it. "Added some code to fix the bug"? :)

The summary is for the committer and reviewer(s).

Looking at hte code see there is a new check what's it checking? This may help write one https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →

Not adding one will most likely delay the issue until someone wants to get the information the long way.

Will keep in review though

MR works fine. So I changed status to RTBC

All I have noticed is that multiple if-else condition with several & operators to check
I think it should be more readable and also there are few suggestions already done on the MR by community, hence moving into NW

Just doing some cleanup.

MR works fine. So I changed status to RTBC

Not entirely sure #63 was handled. There is still quite a lot of if elseif else nesting being added here which increases the code complexity/readability.