We would like to add support for deleting items that are no longer present in the incoming data when a migration is run. This was a feature of Feeds in D7 and seems like a common need.
From @mikeryan in #15:
I really think this should be a distinct "purge" operation that gathers the currently-available source IDs from the source plugin, and scans the map table for any which aren't in that list to invoke the destination rollback on them. Now that I think about it, maybe it could even be an option on rollback -
drush migrate-rollback --missing-from-source my_migration.
Two tests added and passing tests.
At this point, testing is a little complicated. The current patch (in Comment #136) adds an interface and a trait. In order for selective rollback to work, your migration source plugin needs to implement the interface. An easy way to do that is by using the trait. For examples, see the code snippet below the following steps.
drush mr my_migration --missing-from-source.For Step 4, you can follow the example in the SyncableEmbeddedDataSource plugin that is added in this issue. That class is used in the new MigrateRollbackMissingTest test class. Here is a class that @marvil07 wrote for a client project that uses the patch from this issue:
namespace Drupal\my_migrate\Plugin\migrate\source;
use Drupal\migrate\Plugin\MigrationInterface;
use Drupal\migrate_plus\Plugin\migrate\source\Url;
use Drupal\migrate_tools\Plugin\migrate\source\SyncableSourceTrait;
use Drupal\migrate_tools\SyncableSourceInterface;
/**
* A syncable url source using SyncableSourceTrait.
*
* @see Drupal\migrate_plus\Plugin\migrate\source\Url
*
* @MigrateSource(
* id = "syncable_url",
* source_module = "my_migrate"
* )
*/
class SyncableUrl extends Url implements SyncableSourceInterface {
use SyncableSourceTrait;
/**
* {@inheritdoc}
*/
public function __construct(array $configuration, $plugin_id, $plugin_definition, MigrationInterface $migration) {
parent::__construct($configuration, $plugin_id, $plugin_definition, $migration);
$this->setAllRowsFromConfiguration();
}
}
N/A
N/A
Fixed
4.0
Code
It denotes an issue that prevents porting of a contributed project to the stable version of Drupal due to missing APIs, regressions, and so on.
The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
In 9.1 the order of the arguments to dispatch() changed, and so the previous patches stop working in those higher version of Drupal. In testing, just re-ordering the arguments in all calls to dispatch() works to restore this feature to functioning.
I've updated the latest patch with @ddavisboxleitner's comment about dispatch.