'More link' option should be configurable for views page displays

Patch #88 applied successfully

Issue summary still needs updating per #80

I didn't get same results as #80 but it's not working as expected.

I tested using the Content view.
If I set the more link to the page then it just redirects back to the page I'm on
If I give it custom URL it's passing all the filter variables to it test?title=&type=All&status=All&langcode=All

So don't think this is working correctly.

Also shows the test coverage needs to be expanded.

Hi @smustgrave

I tried to reproduce the issue and it seems to be working for me.

If I set the more link to the page then it just redirects back to the page I'm on

This is partially because of the confusing naming convention may be.
When we are on the modal to select the more link page, it shows the name of view's display.
You might have selected the same page i.e. "page" (option 3 in the following screenshot), which is same page.
So link might be taking you to the same page.

I have added another test case where we are linking a separate page (page_2) from page_1 view. This might clarify things further.
Keeping the "needs tests" tag for now until we are sure that we have sufficient test coverage.

If I give it a custom URL it's passing all the filter variables to it test?title=&type=All&status=All&langcode=All

I think this change was introduced in http://drupal.org/node/564106. So probably this is by design.
When we have any exposed form, view the exposed_raw_input from the current view and appends to more-link.
Happy to have feedback from other forks about how we should proceed further.

+++ b/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
@@ -685,7 +685,7 @@ public function hasPath() {
   public function usesLinkDisplay() {
-    return !$this->hasPath();
+    return TRUE;
   }

For an issue that wants to add this to Page displays, changing this in the base class sounds way too generic and might break BC for modules adding pathed displays that don't want this.

Not totally sold on needing to support this in core, since looking at this, all you would need to do is add a new display plugin "Page with more link" that extends path but returns true for usesLinkDisplay(), pretty trivial, but ¯\_(ツ)_/¯

The Patch #94 ✨ 'More link' option should be configurable for views page displays Needs work works for me on Drupal 10.2.3, php 8.1.2. Thanks.

Rerolled the patch #94 with 11.x.

@sakthi_dev, I think patch is already getting applied on 11.x
We probably don't need to re-roll the patch.
Can you please upload the re-roll diff, if possible.