Autocomplete expands dialog contents

Created on 5 November 2015, about 9 years ago
Updated 18 October 2024, about 1 month ago

Problem/Motivation

The Entity Embed module displays a text field with autocomplete in a Dialog. When using the Classy dialog CSS (i.e. embedding entities using Quick Edit with Bartik) the autocomplete entries expand the dialog content instead of overflowing off of the dialog.

Steps to reproduce

  • Install Drupal 9.5 with standard profile
  • Install Entity Embed module
  • Install CKEditor module (cke4)
  • Switch the Basic HTML text format to use cke4, add the entity embed plugin to the editor toolbar
  • Create 3 or 4 article nodes, just setting the titles all starting with the word "test"
  • Create another article node. In the ckeditor click the entity embed button and type "test"
  • The results should appear correctly
  • Switch the admin theme to stark and try again, the results will be clipped
🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component

CSS

Created by

🇨🇦Canada devin carlson Sudbury, ON

Live updates comments and jobs are added and updated live.
  • CSS

    It involves the content or handling of Cascading Style Sheets.

  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

  • Needs manual testing

    The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India nayana_mvr

    Verified this issue in Drupal 10.4.x as Entity embed module is not compatible with D11. The css code added in #2 patch has been already implemented for the Claro (core admin theme) so this issue is not reproducible with Claro theme (current core admin theme). As for Olivero (core default theme), the dropdown is still clipped with a scroll in the dialog but I think it is fine because in Olivero 'Next' button is coming in the left bottom. If dropdown is not clipped, it will overlap on the 'Next' button. I'm not sure whether we need to make any changes at system level now since already theme level fix is implemented for Claro. Attaching screenshots for reference.

    Claro:

    Olivero:

  • 🇮🇳India nayana_mvr

    Marking it as 'Needs Review' to get feedback from maintainer.

Production build 0.71.5 2024