FilterUninstallValidator stops uninstall when module being uninstalled is only one using a filter format

Created on 9 November 2015, almost 9 years ago

Updated 29 October 2023, 10 months ago

Problem/Motivation

When trying to uninstall mailchimp_campaign, FilterUninstallValidator returns an error because mailchimp_campaign is using that filter. It's good to check whether other modules are using that filter, but since we are uninstalling mailchimp_campaign, it seems like it should get through the validation without worrying about its own filter.

The error from #2585215: Mailchimp Campaign cannot be uninstalled →

The following extensions will be uninstalled: mailchimp_campaign
Do you really want to continue? (y/n): y
exception 'Drupal\Core\Extension\ModuleUninstallValidatorException' with message 'The following reasons prevents the modules from [error]
being uninstalled: Provides a filter plugin that is in use in the following filter formats: MailChimp
campaign'

And from the duplicate issue 🐛 Impossible to uninstall a module that provides a config override for a filter Closed: duplicate .
The Filter module implements an UninstallValidator that prevents a module from being uninstall if it provides a filter plugin that's actively being used by some filter. To resolve it, a site admin must simply remove the filter plugin from any active filters.

However, if the filter plugin is enabled on a filter by means of a configuration override, then there is no way to remove it. If the module providing the override is the one you want to uninstall, it's impossible.

Steps to reproduce

TBA

Proposed resolution

TBA

Remaining tasks

Steps to reproduce
Patch, with test
review
commit

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Extension →

Last updated 5 days ago

No maintainer

Created by

🇺🇸United States jami

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Needs manual testing
The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

Needs steps to reproduce

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇳🇿New Zealand quietone New Zealand
Closed 🐛 Impossible to uninstall a module that provides a config override for a filter Closed: duplicate as a duplicate and updated the Issue Summary. Moving to extension system because this is about module uninstall.
Comment 10 months ago →
🇩🇪Germany IT-Cru Munich
We run into this issue on Drupal 9.5.x with amazon_onsite contrib module which provide a CKEditor 4 plugin which was used in one of our editor and text filter configs.

Patch from #12 applied fine and fixed this uninstall issue in our case. When our internal QA process is finished I could give feedback with Drupal 10.1.x.

+1 RTBC
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
30,472 pass

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024