Contrib.social

Field creation error needs correct cleanup

Open on Drupal.org →
Created on 16 November 2011, over 13 years ago
Updated 9 February 2023, about 2 years ago

Problem/Motivation

When field creation via GUI is failed, you may have in your DB unused table(s).

Steps to reproduce

The simplest way to imitate/reproduce the case is:

  • in your DB create a dummy table with name field_revision_field_sample;
  • open admin/structure/types/manage/page/fields , try to add field field_sample with text type;

As a result you will have newly created table field_data_field_sample in your database which not belongs to any field.

Proposed resolution

Similar to action of updating field, we enclose tables creation in transaction, either manual or provided by DB. See field_sql_storage_field_storage_update_field().

Remaining tasks

Update the patch, taking into account the review in #8 🐛 Field creation error needs correct cleanup Needs work
Review

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Needs work

Version

10.1 ✨

Component
Field  →

Last updated about 4 hours ago

Created by

🇪🇸Spain dpovshed

Live updates comments and jobs are added and updated live.
  • Needs backport to D7

    After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

  • Needs manual testing

    The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    🇳🇿New Zealand quietone

    I tested this on Drupal 10.1.x, standard install using the steps in the Issue Summary. I was able to reproduce the problem. The error I get when trying to add a field 'sample' to a page is
    The website encountered an unexpected error. Please try again later.

    Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'field_sample_value' in 'where clause': SELECT 1 AS "expression" FROM "node_revision__field_sample" "t" WHERE "field_sample_value" IS NOT NULL LIMIT 1 OFFSET 0; Array ( ) in Drupal\Core\Entity\Sql\SqlContentEntityStorage->countFieldData() (line 1787 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

    The patch needs to be updated, with #8 in mind.

  • Comment 2 months ago →
    🇳🇿New Zealand quietone
  • Comment 2 months ago →
    🇨🇦Canada mgifford Ottawa, Ontario

    How would one create this without modifying the database? How does this crop up, without doing something that 99% of site builders don't do?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024