- Issue created by @Gábor Hojtsy
- 🇭🇺Hungary Gábor Hojtsy Hungary
This is where the code lies to check it https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/syste... we should see if we can reuse this by invoking it instead of copying it.
- Assigned to joaopauloscho
- Merge request !92Issue #3420355: Add db updates environment status → (Open) created by joaopauloscho
- Issue was unassigned.
- Status changed to Needs review
6 months ago 7:35pm 24 June 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Gábor Hojtsy → changed the visibility of the branch 3420355-upgrade-status-does to hidden.
- Status changed to Needs work
6 months ago 8:31am 8 July 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Thanks for working on this. I think the more we can reuse rather than copying it to our own would be better. Reviewing system_requirements(), there are various useful things it checks for that could affect upgrades, eg. module installed that is already not compatible with current version of core, missing module installed, entity updates missing, etc. These are beyond the database updates missing. So I think we may be better off with running the system requirements check and reporting if there were ANY errors from there. That would not be that specific about database updates, but it would help surface system issues.
- Status changed to Needs review
6 months ago 8:44am 8 July 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Made an untested proposal, manual testing is welcome. Not sure how can we automatically test this. (We don't really have tests for the requirements checks unfortunately).
Nice, it makes sense! Tested it and noticed an error related to the system_requirements() function, so I've pushed a fix for it. Can you review please? Thanks.