- Issue created by @fnalb2
- Status changed to Needs review
over 1 year ago 9:16am 24 July 2023 - last update
over 1 year ago 29,878 pass - 🇬🇧United Kingdom longwave UK
How are you finding these duplicate selectors? Is there an Stylelint rule or similar we can enable to detect these across core?
Also we usually fix bugs by type of bug, not file by file - please read https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... → before opening any more issues along these lines.
- Status changed to Needs work
over 1 year ago 12:30pm 24 July 2023 - 🇺🇸United States smustgrave
Dubbing this one the main ticket and closed the others.
As @longwave mentioned this should be fixed with a stylelint rule if possible.
Brought up in #needs-review-queue-initative with @longwave and @lauriii
Each change will have to be manually tested for regression. Recommendation is to find more pressing issues though.
- Status changed to Needs review
over 1 year ago 8:01am 26 July 2023 - last update
over 1 year ago 29,881 pass - 🇷🇺Russia kostyashupenko Omsk
Big tests required.
Added
'cascade-layers': false
feature in PostcssPresetEnv incore/scripts/css/compile.js
. Reason -!important
CSS rule without chis change always compiling into separate selector (which brings duplicates of selectors). However with this setting or without - i didn't meet any changes onbuild
task, so it's a rudiment for us.All selectors were replaced carefully
- 🇩🇪Germany fnalb2
@longwave: I used SonarQube from https://www.sonarsource.com/
- Status changed to Needs work
over 1 year ago 4:25pm 5 August 2023 - Status changed to Needs review
over 1 year ago 6:35am 7 August 2023 - last update
over 1 year ago Custom Commands Failed - Status changed to Needs work
over 1 year ago 1:08pm 7 August 2023 - Status changed to Needs review
over 1 year ago 3:49am 16 August 2023 - last update
over 1 year ago 29,959 pass - 🇮🇳India gauravvvv Delhi, India
Fixed coding standard, attached interdiff for same.
- Status changed to Needs work
over 1 year ago 11:36am 22 August 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 6:14am 30 November 2023 - Status changed to Needs work
about 1 year ago 6:48am 30 November 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 1 year ago 9:50am 30 November 2023 - Status changed to Needs work
about 1 year ago 10:28am 30 November 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 1 year ago 2:56pm 3 December 2023 - Status changed to Needs work
about 1 year ago 3:27pm 3 December 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Merge request !5699updated stylelint and updated duplicated selectors → (Open) created by Unnamed author
- Status changed to Needs review
about 1 year ago 4:33am 6 December 2023 - Status changed to Needs work
about 1 year ago 4:14pm 19 December 2023 - Status changed to Needs review
about 1 year ago 4:06am 20 December 2023 - 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 11.x to hidden.
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch djsagar-3aebe704-patch-6232 to hidden.
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch djsagar-be735a74-patch-4956 to hidden.
- Status changed to Needs work
about 1 year ago 8:08pm 21 December 2023 - 🇺🇸United States smustgrave
Left some comments if they can be answered. Reviewed maybe 3/4s of the MR.
- Status changed to Needs review
about 1 year ago 3:31am 22 December 2023 - 🇮🇳India gauravvvv Delhi, India
I have addressed all feedbacks, please review
- Status changed to Needs work
12 months ago 1:18am 27 December 2023 - 🇺🇸United States smustgrave
Still appears to be an open thread.
Also needs merge conflicts resolved.
- Status changed to Needs review
12 months ago 4:01am 27 December 2023 - Status changed to Needs work
12 months ago 5:11pm 28 December 2023 - Status changed to Needs review
12 months ago 3:09am 29 December 2023 - 🇮🇳India gauravvvv Delhi, India
Addressed the thread @smustgrave. Setting the status as needs review
- Status changed to RTBC
12 months ago 8:07pm 30 December 2023 - last update
12 months ago Patch Failed to Apply - last update
12 months ago Patch Failed to Apply - last update
12 months ago Patch Failed to Apply - last update
12 months ago Patch Failed to Apply - last update
12 months ago Patch Failed to Apply - Status changed to Needs work
10 months ago 11:37pm 20 February 2024 - Status changed to Needs review
8 months ago 2:21pm 3 May 2024 - 🇫🇷France nod_ Lille
didn't review everything, what i saw looked much better, thanks :)
- Status changed to Needs work
8 months ago 1:34pm 6 May 2024 - 🇺🇸United States smustgrave
Didn't review, MR has failures and some open threads.
- 🇮🇳India gauravvvv Delhi, India
I updated the nesting, which was asked to be reverted in #40, just to fix these CSS linting issues. The lines showing the failure are not changed in the MR (reverted them).