- 🇺🇸United States selwynpolit
Maybe I am missing something but I was not able to make the expiration time change using #25. I haven't tried the patch yet, but that seems like a good way to go.
- Assigned to KeyurHShah
- Status changed to Needs review
about 1 year ago 12:39pm 27 September 2023 - last update
about 1 year ago 29,640 pass Core: Drupal 10
TypeError: Drupal\Core\TempStore\SharedTempStore::__construct(): Argument #5 ($current_user) must be of type Drupal\Core\Session\AccountProxyInterface, int given, called in /core/lib/Drupal/Core/TempStore/SharedTempStoreFactory.php on line 111 in Drupal\Core\TempStore\SharedTempStore->__construct() (line 106 of core/lib/Drupal/Core/TempStore/SharedTempStore.php).- last update
about 1 year ago 29,640 pass Core: Drupal 10
TypeError: Drupal\Core\TempStore\SharedTempStore::__construct(): Argument #5 ($current_user) must be of type Drupal\Core\Session\AccountProxyInterface, int given, called in /core/lib/Drupal/Core/TempStore/SharedTempStoreFactory.php on line 111 in Drupal\Core\TempStore\SharedTempStore->__construct() (line 106 of core/lib/Drupal/Core/TempStore/SharedTempStore.php).- last update
about 1 year ago 29,640 pass Core: Drupal 10
TypeError: Drupal\Core\TempStore\SharedTempStore::__construct(): Argument #5 ($current_user) must be of type Drupal\Core\Session\AccountProxyInterface, int given, called in /core/lib/Drupal/Core/TempStore/SharedTempStoreFactory.php on line 111 in Drupal\Core\TempStore\SharedTempStore->__construct() (line 106 of core/lib/Drupal/Core/TempStore/SharedTempStore.php).- Status changed to Needs work
about 1 year ago 6:26pm 12 October 2023 - 🇺🇸United States smustgrave
Previously tagged for tests which are still needed.
Have not tested
- 🇺🇸United States angrytoast Princeton, NJ
angrytoast → changed the visibility of the branch 2883521- to hidden.
- 🇺🇸United States angrytoast Princeton, NJ
angrytoast → changed the visibility of the branch 2883521-expose-expire to hidden.
- 🇺🇸United States angrytoast Princeton, NJ
angrytoast → changed the visibility of the branch 2883521-expose-expire to active.
- 🇺🇸United States angrytoast Princeton, NJ
angrytoast → changed the visibility of the branch 11.x to hidden.
- Merge request !5975SharedTempStoreFactory and PrivateTempStoreFactory $expire variable should be changeable for each collection → (Open) created by angrytoast
- Issue was unassigned.
- Status changed to Needs review
11 months ago 1:27am 29 December 2023 - 🇺🇸United States angrytoast Princeton, NJ
Setting issue back to 11.x as the active development branch and back to Feature request as this is net new functionality and not a bug.
Opened a new MR -- https://git.drupalcode.org/project/drupal/-/merge_requests/5975 -- against 11.x as it wasn't clear how to change the target of the existing MR against 9.3.x
Changes include:
- Starting from the patch state of #36
- Updates to moreSharedTempStore::set
related methods that are also affected by$expire
- Updated tests for Private/Shared Tempstore classes
- Typehinting for params and returns in affected code - Status changed to Needs work
11 months ago 11:54pm 1 January 2024 - 🇺🇸United States smustgrave
Hiding patches for clarity.
Issue summary looks like it could use some love. I added the standard template but not familiar enough with the issue to fill in the missing pieces. Left TBD for ones that could be filled out, if it doesn't apply just replace with an NA.