- Issue created by @Taran2L
- Merge request !9Issue #3478474 Add a BC layer for service argument change β (Merged) created by Taran2L
- π©πͺGermany Anybody Porta Westfalica
Thank you very very much @taran2l for providing the example! LGTM!
@Grevil what would you say?Any further references in the docs that it should be done this way? (Technically it makes sense to me, but also adds some boilerplate)
@taran2l added a good explanation here:
@anybody hi
Unfortunately, this is not how this thing should be fixed, as update runs after cache rebuild (usually), so I can't get to that.
Core always adds a BC layer when arguments change, this should be done here as well.
https://www.drupal.org/project/twig_field_value/issues/3471185#comment-1... π 2.0.3 update should containers Fixed
- π©πͺGermany Grevil
Wow, that is super annoying for such a simple change! Haven't seen that yet.
One last thing:
\Drupal\twig_field_value\Twig\Extension\FieldValueExtension::__constrcut() now requires a 5th parameter of type \Drupal\Core\Render\RendererInterface
=> __construct().
That's crazy though... one more reason to actually not use dependency injection....
- π©πͺGermany Grevil
Alright, changed the CR typo myself.
Should be good to go now!
-
grevil β
committed 69fc4106 on 2.0.x authored by
taran2l β
Issue #3478474 Add a BC layer for service argument change
-
grevil β
committed 69fc4106 on 2.0.x authored by
taran2l β
Automatically closed - issue fixed for 2 weeks with no activity.