In
📌
Make CI green again
Active
we had to disable testing on 11.2.x branch by commenting out the OPT_IN_TEST_NEXT_MINOR in .gitlab-ci.yml due to two deprecations detected by phpstan here:
https://git.drupalcode.org/issue/svg_image_field-3501734/-/jobs/4109765
------ -----------------------------------------------------------------------
Line svg_image_field.views.inc
------ -----------------------------------------------------------------------
19 Call to deprecated function views_field_default_views_data():
in drupal:11.2.0 and is removed from drupal:12.0.0. Use
\Drupal::service('views.field_data_provider')
->defaultFieldImplementation($field_storage); instead.
🪪 function.deprecated
48 Call to deprecated function views_entity_field_label():
in drupal:11.2.0 and is removed from drupal:12.0.0. Use
\Drupal::service('entity_field.manager')->getFieldLabels() instead.
🪪 function.deprecated
------ -----------------------------------------------------------------------
The related CRs for these two deprecations include:
OPT_IN_TEST_NEXT_MINOR: 1 in .gitlab-ci.ymlProperly handle the deprecated functions following best practices.
Active
2.3
Code
Went ahead and fixed this .... still supporting 9.5, it's up to you if you want to go like that
Yes, for now the D9 compatibility should be kept. Eventually it makes sense to remove support but since it is not a burden yet, were okay to keep it. will review and test soon. Thanks so much for collaborating.