Account created on 6 December 2011, almost 13 years ago
#

Recent comments

🇵🇪Peru cordoval
  1. +++ b/composer.json
    @@ -23,12 +23,16 @@
    +    "symfony/console": "2.4.*",
    

    this dependency shouldn't be ~2.4 instead of 2.4.*?

  2. +++ b/core/lib/Drupal/Console/Command/CommandBootstrapBase.php
    @@ -0,0 +1,73 @@
    +    require_once __DIR__ . '/../../../../includes/bootstrap.inc';
    

    i thought the drupal api already autoloaded all that needs to be autoloaded?

  3. +++ b/core/lib/Drupal/Console/Command/CommandBootstrapBase.php
    @@ -0,0 +1,73 @@
    +      $container = $kernel->getContainer();
    ...
    +      $container->get('request_stack')->push($request);
    

    have you checked how app/console container:debug does it? i think if the container is dumped there may be no need for this

  4. +++ b/core/lib/Drupal/Console/DrupalApplication.php
    @@ -0,0 +1,72 @@
    +  private function discoverCommands() {
    

    can we totally avoid this type of stuff and just $this->add(new CommandHere) ?

    or maybe instead of having this let's tag the service commands definitions and let the compiler pass gather the right commands needed. Having this instead is really ugly and prone to all sort of messiness.

  5. +++ b/core/lib/Drupal/Core/Discovery/DrupalFinder.php
    @@ -0,0 +1,94 @@
    +      $drupal_root = realpath(dirname(dirname(dirname(dirname(dirname(dirname(__FILE__)))))));
    

    please do not repeat symfony's way of doing this if we can register the command as services

Production build 0.71.5 2024