rename locale batch operation callbacks to match the API methods they call

Thanks for the MR. Looks goo!

These are procedural functions without a leading underscore, we should leave the old one as wrappers and deprecate them.

Someone should rebase the branch before a novice works on it -- it looks like it's been merged rather than rebased, which is going to make the history messy.

Actually, I think it just conflicts with 📌 Deprecate Drupal\locale\Locale and its one method Fixed . I'll rebase it onto the commit right before that, but someone will need to advise on the new direction. I.e., does the new scope becoming reconciling it with the afore-mentioned #3422915? Or is this no longer a novice issue--or even obsolete?

MR currently have some phpcs errors.

I agree with #11 and #12; this is not Novice for right now. Thanks!

Rebased on 11.x and resolved the conflict.

This is good for novices again -- see #5 for what needs doing.

Agreed, thanks @joachim!

There is also a coding standards issue to resolve:

--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 16 | ERROR | [x] Opening brace should be on the same line as the declaration
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 16.64 secs; Memory: 8MB
PHP CODE SNIFFER REPORT SUMMARY
-------------------------------------------------------------------------------

Left some comments on the MR.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Marking this again as Needs Review as PHPSTAN is already passing in the pipeline.

So function renaming should have a change record and deprecations should point to that vs the ticket.

Thanks

These are internal functions. They're batch API callbacks, they're not going to be used anywhere else.

Personally still think a CR should be made so will leave for additional reviewers.

Deprecations will have to be updated for deprecated in 11 removed in 12.

Updated deprecations to be 11.1.0. Could you please review MR !6742. Thanks!

Thanks. I should of caught this before so my bad. But we will need a change record to announce the deprecation. And the links in the deprecation needs to be with that CR link.

CR can be pretty simple, would look through existing ones in the change records list.

Hey, made the CR which can be found here: https://www.drupal.org/node/3475054 → . Also replaced the issue links in the MR with this link. Please can this be reviewed again.

Thanks! Believe this one is good

I read the issue summary, comments and the MR. Everything looks in order here. The deprecation messages in the docblocks don't need to list the function arguments but it is also not wrong. So, leaving that as is. And thanks for the nicely formatted change record, it is is easy to read.
I updated credit.

Leaving at RTBC.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Working on it.

@secretsayan asked me to push this change for him real quick because he's in the process of moving to a new laptop.

Failure seems unrelated, re-running. Resolved the threads while I was at it. Bot feedback appears addressed.

Committed and pushed 6b6facdc29e to 11.x and 167dc216f33 to 11.1.x. Thanks!

Congratulations on your first Core commit, @secretsayan! 😄

Thanks @traviscarden :)

Automatically closed - issue fixed for 2 weeks with no activity.