- Issue created by @joachim
- last update
about 1 year ago 36 pass - @joachim opened merge request.
- Status changed to Needs review
about 1 year ago 10:48am 30 October 2023 - πΊπΈUnited States amaisano Boston
Does this only break it up within the current module, or can it be made so that we can reference different module's shared migration file(s)? Would be nice to have cross-module migration shared yml files (like a family of sub modules where the parent module has a common set of migrations, and the sub modules that each deal with different parts of the migration have more specific shared migration).
- π¬π§United Kingdom joachim
> Does this only break it up within the current module, or can it be made so that we can reference different module's shared migration file
The migration includes are merely plugins -- you can reference any plugin of that type in any migration. That's already the case with the current code.
- πΊπΈUnited States amaisano Boston
So cross-module use of the shared_configuration YAML data is possible w/o this patch? Like so:
/my-migrations --/modules --/--/node_migration --/--/--/node_migration.migrate_shared_configuration.yml (with a "defaults" include definition) --/--/term_migration --/--/--/term_migration.migrate_shared_configuration.yml (with a "taxonomy" include definition) --/--/misc_migration --/--/--/migrations --/--/--/--/misc_migration.yaml (with contents below) # Misc Migration id: misc_migration includes: - defaults - taxonomy source: ...
?
- π¬π§United Kingdom joachim
AFAICT, yes. I had a quick look in the code of MigrateIncludeHandler and it's not doing any doctoring to the 'include' value.
- πΊπΈUnited States amaisano Boston
It would be nice if you could still group multiple inside a single YML file, especially when you have multiple override "snippets" that are only a few lines -- creating a separate file for all of them is a bit overwhelming.
defaults.yml - include1: - source: - constants: - a: 1 - include2: - source: - constants: - b: 2 - include3: - source: - constants: - c: 3 big_complex_field.yml - process: - field_paragraphs: - plugin: ...
- πΊπΈUnited States amaisano Boston
Also, sub-folders under migrate_shared_configuration/ would be nice:
- migrate_shared_configuration/node/bundle_1.yml - migrate_shared_configuration/node/bundle_2.yml - migrate_shared_configuration/term/vocab_1.yml
- Status changed to RTBC
about 1 year ago 8:19pm 29 November 2023 -
heddn β
committed 58e60e82 on 6.0.x authored by
joachim β
Issue #3397621 by joachim, heddn: Change migration include plugins to...
-
heddn β
committed 58e60e82 on 6.0.x authored by
joachim β
- Status changed to Fixed
about 1 year ago 8:19pm 29 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.