Add methods to `AutoSaveEntity` value object to simplify auto-save infrastructure

Created on 11 July 2025, 3 days ago

This:

lives in an odd place (AutoSaveValidateTrait::getClientAutoSaveData — a trait that exists only for validation purposes while it must also actually be generated & passed to the client when not validating)
also lives at AutoSaveManagerTestTrait::getClientAutoSaveData()
and #3535315 added additional caching complexity for it

It's all necessary complexity! 👍 … but it could be organized differently, to better manage that complexity. 🙏

We already have the \Drupal\experience_builder\AutoSaveEntity value object. But we're barely using it.

Use it for more.

Zero.

📌 Task

Status

Active

Version

0.0

Component

Auto-save

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @wim leers
Comment 3 days ago →
🇺🇸United States tedbow Ithaca, NY, USA
@wim leers thanks for creating this follow-up. I started an MR on the other issue to show an similar idea https://git.drupalcode.org/project/experience_builder/-/merge_requests/1270

I will move some of that work here
@tedbow opened merge request.
Comment 3 days ago →
🇺🇸United States tedbow Ithaca, NY, USA
I pushed up the changes I had started on the other issue.

Instead of adding AutoSaveEntity::getLiveStartingPoint() I added AutoSaveManager::calculateStartingPoint()

I think the starting point needs to calculated at 2 points

In AutoSaveManager::saveEntity() if there is no existing auto-save entry

In \Drupal\experience_builder\Controller\AutoSaveValidateTrait::getClientAutoSaveData() there is no auto-save entry

Production build 0.71.5 2024