[PP-1] Enforce conflict enforcement outside of tests and e2e tests

Created on 28 May 2025, 6 days ago

Overview

Follow-up to 📌 Add rudimentary conflict prevention to the preview end-point Active
In that issue we put in logic to throw an exception if client didn't send the latest auto-save hash for the entity and regions. This prevents 2 users for editing at the same time and wiping out each others changes

Trying to get the e2e tests to pass I discovered that rapid fire requests could cause this exception to be trigger without only 1 user editing the page.

So we decided to scope #3490565 to just the backend parts

Proposed resolution

In \Drupal\experience_builder\Controller\ApiLayoutController::validateAutoSaves() remove the special casing for phpunit tests.
Bring back the logic that was taken out of 📌 Add rudimentary conflict prevention to the preview end-point Active to send the autoSaves key from the client(commit link soon)
Implement system to handle rapid fire requests

User interface changes

📌 Task

Status

Postponed

Version

0.0

Component

Page builder

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.

stable blocker

Merge Requests

!1080[PP-1] Enforce conflict enforcement outside of tests and e2e tests
Open
🇺🇸United States tedbow
updated 5 days ago

Comments & Activities

Issue created by @tedbow
Comment 6 days ago →
🇺🇸United States tedbow Ithaca, NY, USA
Comment 6 days ago →
🇺🇸United States tedbow Ithaca, NY, USA
Merge request !1080Resolve #3526907 Client auto-save conflicts → (Open) created by tedbow
Comment 5 days ago →
🇺🇸United States tedbow Ithaca, NY, USA
I brought in the changes from 📌 Add rudimentary conflict prevention to the preview end-point Active because I made progress getting the e2e test to pass, so I thought I would the current state
Comment 5 days ago →
🇺🇸United States tedbow Ithaca, NY, USA
The only 2 e2e tests that are failing now are `entity-form-field-types-test.cy.js` which does pass for me locally and `media-library.cy.js` which did fail locally but I didn't see an 409 request errors in the log. So maybe these are unrelated random test errors? Not sure, retesting

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024