- Issue created by @tedbow
- 🇺🇸United States tedbow Ithaca, NY, USA
Before we can start doing the back-end changes for this, will to decide on the 1 current item in "Remaining questions"
This is really a product question so assigning to Lauri
My vote would be option 3. We require the client to list of all entity keys regardless of whether they will be published but all have to match the auto-save has for changes that will be published.
This seems like a good balance of making sure the user is aware changes but also not stopping publishing of some items if another item is actively being edited in XB
- 🇺🇸United States tedbow Ithaca, NY, USA
I chatted with @laurii and we agreed that for "Remaining questions 1" option 2 is best.
this means the client will only has to send the information for the changes it wants to publish.
This will mean even if there "Review X changes" list does not have the most recent entries or isn't aware that some entities might have been deleted that is ok because we poll the server every 10 seconds. But we will also create a child issue here to ensure that "Review X changes" list request has been made in the last 10 seconds. This way if gets bunch of network errors and their "Review X changes" is very old they will a new successful request before they can publish. This will ensure they should have nearly up-to-date list
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
FYI in testing 📌 Add e2e tests for moderation state in page data form Active I found that the moderation state takes precedence over the
setPublished
call in the auto save controller.i.e. With content moderation enabled for a node if the user selects 'Draft' in the page data form and then hits 'publish all changes' their wish to keep something as a draft is respected
Might be something worth taking into account here.
- 🇺🇸United States tedbow Ithaca, NY, USA
re #4
But we will also create a child issue here to ensure that "Review X changes" list request has been made in the last 10 seconds.
Created child issue 📌 Ensure that client "Review X changes" is updated periodically Active
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 When publishing only require the client to send information for the subset of changes they want to publish Active is in — yay, congrats!
But … there's no way to tell based on looking at the meta how much work remains. Can you please update this meta to provide a sense of progress? 🙏 See 🌱 [META] Production-ready data storage Active 's
#beta
fragment/section for an example :)P.S.: changed from to , not a bug.
- 🇺🇸United States effulgentsia
I moved the "beta blocker" tag to just 📌 Create UI for selective publishing of changes Active and tagged the other children as "stable blocker".
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@tedbow: can you please confirm ✨ Publish all changes within a database transaction to allow rollbacks Active is still okay as a rather than a ?
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 For selective reverting add DELETE auto-save endpoint Active is in.