Account created on 4 May 2008, over 16 years ago
#

Merge Requests

Recent comments

🇦🇺Australia thtas

I've created a d11 release from your merge request. we also use this in a number of sites which are in the process of being upgraded so much appreciated.

At this time i don't think we need add any additional maintainers though.

🇦🇺Australia thtas

Unfortunately, Basic Authentication is not a "global" authentication provider by default. Meaning you can only use it to authenticate against routes which explicitly allow it. (e.g. JSON api and REST api routes).

The private file download route does not define an "_auth" option in it's route, so it will only work with cookie based authentication or any other enabled providers which are marked as global.

🇦🇺Australia thtas

Which formatter plugin was this with? I believe the config schema is correct (sequence makes sense to me anyway), so the problem seems more about how the formatter is saving these values.

🇦🇺Australia thtas

I've just run in to this too. Annoyingly it only seems to manifest during gitlab ci test runs, so tricky to debug.

We're not doing any ajax requests, and the problem goes away when I disable big_pipe.

The library which is being added twice is "facets/drupal.facets.link-widget" (and it's duplicated at the end of the libraries array).

🇦🇺Australia thtas

Updated for latest 8.x-1.x branch

🇦🇺Australia thtas

My solution for this was to override the queue processor class with our own.

As it's processing each item, we check if a user exists with that email, then re-load the template in the users preferred language.

It would might be better if the queue items included the user being notified rather than the email address. This would also catch the case of a user changing email addresses before the queue item was processed.

Attached is my override in case anybody else finds it useful.

🇦🇺Australia thtas

In addition, I've found that the permission string used to check for access to any un-published entities was not correct.

Patch updated.

🇦🇺Australia thtas

Indeed it was!

My problem was occurring during integration tests, where for whatever reason we were adding the "member" role explicitly to group memberships during our test setup phase. There is no need to do this (there probably never was), and this caused the error here.

Thank you for the quick response Kristian.

🇦🇺Australia thtas

I've just run in to this and debugged as per your suggestion. the Role being returned in "group_membership->getRoles(FALSE)" above is the "[GROUP_TYPE]-member" role, and it has a scope of "insider". It has a number of permissions assigned to it.

The site I'm working is in the process of moving from 1.5.0 to 2.2.1

🇦🇺Australia thtas

Attached is a re-roll against 10.1.x, 10.2.x and 11.x

🇦🇺Australia thtas

The site we're running this on is using commerce_reports 1.0.0-beta2 + this patch (and some others) and working well.
But as mentioned, running on mariadb, not postgres.

🇦🇺Australia thtas

I've not run in to the issue from #68, but I do have a problem when uploading a large image when the browser window is not very high, resulting the modal being resized and the bottom of it gets hidden below the fold. Making the button at the submit button un-clickable. To fix it you have to re-size the window (by just a tiny amount) and the modal position is re-calculated correctly.

I've added a resize event trigger to the resizeIframe method which fixes it for my use-case, but this whole thing is pretty stinky. use at your own risk.

🇦🇺Australia thtas

Thank you for your feedback and glad you find the module useful.

But I think I'd prefer to elect to to leave this up to the particular theme implementation. This module should not really be too opinionated about the theming above adding appropriate classes to the markup. There should be enough classes on the markup for any theme to prepend text or for a theme/module to add text using pre-process hook.

🇦🇺Australia thtas

oh no. I think at one point this did work with epp but something must have changed.

https://www.drupal.org/project/readonly_field_widget/issues/3226251

🇦🇺Australia thtas

Hint for others: Make sure your admin user (user 1) has been granted the drupal role that you link to your group admin role! by default, user 1 does not have any roles.

🇦🇺Australia thtas

I've switched things to use an ajax based widget. it should work along side modules which do validation in their field formatter settings form now.

🇦🇺Australia thtas

I've updated the formatter type selection to use ajax. This means validation should be skipped if that formatter is not selected.

🇦🇺Australia thtas

Thank you for the thorough bug report.

I think this is caused by the way this module only hides the different formatter settings using the drupal #states api, leaving any validation handling to fire even when the form itself is invisible.

As a work-around, you can choose Geocoder as the formatter and select a provider, then switch to plain text and the form should save without the error.

But the real fix is probably to use the drupal ajax api to bring the formatter settings form in.

🇦🇺Australia thtas

Yes this can create some nasty bugs.

We ended up associating terms from the wrong vocabulary because the documentation isn't clear that you both bundle AND bundle_key are required, it just says:

 * - bundle_key: (optional) The name of the bundle field on the entity type
 *   being queried.
 * - bundle: (optional) The value to query for the bundle - can be a string or
 *   an array.

This implies that both are optional and makes no mention that `bundle` is useless without `bundle_key`.

🇦🇺Australia thtas

I've made some improvements to the patch:

1. Checkbox defaults to on if the operator in the facet is set to AND
2. Simplify the JS to remove dependency on jquery.once and reduce complexity of url modification logic.
3. Touch less of the filter build array when the operator is not exposed.
4. Added label to the checkbox.

🇦🇺Australia thtas

Patch attached to just use min-width. Not ideal, but better than "width:200px"

Production build 0.71.5 2024