Contrib.social

When intersect of menu link new definition values attempts to update those not allowed to be overridden throw an exception

Open on Drupal.org →
Created on 14 July 2014, almost 11 years ago
Updated 9 April 2025, about 1 month ago

Problem/Motivation

In #2301239: MenuLinkNG part1 (no UI or conversions): plugins (static + MenuLinkContent) + MenuLinkManager + MenuTreeStorage → noticed that it would make sense to throw an exception instead of silently ignoring values that were attempted to be updated.

Proposed resolution

Find all the places like

  public function updateLink(array $new_definition_values, $persist) {
    // Filter the list of updates to only those that are allowed.
    $overrides = array_intersect_key($new_definition_values, $this->overrideAllowed);

Throw an exception if a value in $new_definition_values was for a key not allowed in overrideAllowed.

Remaining tasks

User interface changes

No.

API changes

Exception thrown.

Postponed until

#2256521: [META] New plan, Phase 2: Implement menu links as plugins, including static admin links and views, and custom links with menu_link_content entity, all managed via menu_ui module →

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

menu system

Created by

🇺🇸United States yesct

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 month ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024