- Issue created by @Ishani Patel
- Merge request !585Issue #3522829: Add custom validation to require either prompt or image in... → (Open) created by Unnamed author
- 🇮🇳India Ishani Patel
Hello,
I've added custom validation for the prompt and image.
Created MR.
Please check and review.Follow the working screenshot after applying validation in Embedding Generation Explorer.
Thank you!
- 🇮🇳India prashant.c Dharamshala
@ishani
I tried it on 1.1.x of ai and without even entering anything in these fields i got some response data. In addition to this also got the validation message but the form still got submitted it seems.
- 🇮🇳India Ishani Patel
Hello Everyone,
I've added validation regarding changes for all the AI API Explorer.
Please check and review.Thank you!
- 🇮🇳India prabha1997
I tried it on 1.1.x of ai branch, and it is working as expected. Please refer to the attached screenshot for reference.
- 🇮🇳India Ishani Patel
Hey @prabha1997,
Can you please check for all other explorer as I done changes for all. - 🇮🇳India prabha1997
I’ve tested all explorers after the changes, and everything is working as expected.
- 🇩🇪Germany marcus_johansson
Hi @ishani patel - great work, would it be possible for you to merge with 1.1.x, so I don't mess that up - after that I'll test the Chat explorer (the file that has merge conflicts) and merge it. Thanks
- Merge request !596Issue #3522829: Add custom validation to require either prompt or image in... → (Merged) created by Unnamed author
- 🇮🇳India Ishani Patel
Hello @marcus_johansson,
I've created a new branch (3522829-to-resolve-validation-conflict).
Resolved the conflict.Please check and merge MR: https://git.drupalcode.org/project/ai/-/merge_requests/596
Thank you!
- 🇮🇳India Ishani Patel
ishani patel → changed the visibility of the branch 3522829-add-custom-validation to hidden.
- 🇩🇪Germany marcus_johansson
It does still break during stream, but this is not regression -looks good. Thank you, getting merged!
-
marcus_johansson →
committed d3bfecf0 on 1.1.x authored by
ishani patel →
Issue #3522829: Add custom validation to require either prompt or image...
-
marcus_johansson →
committed d3bfecf0 on 1.1.x authored by
ishani patel →
Automatically closed - issue fixed for 2 weeks with no activity.