🇮🇳India @prabha1997

Hi @marcus_johansson,
Thanks for sharing access — I’ve checked the sheet. While I understand the data, I’m not yet at the level where I feel confident analyzing and comparing the cost-effectiveness between 4.1 and 4o in depth.

prabha1997 → changed the visibility of the branch 3521769--ai-settings to hidden.

As of now, translation is working correctly with only the required change applied. I’ve removed the extra check and unrelated modifications, keeping the fix minimal and focused on the actual issue.

It worked for me after making the change suggested by @valthebald.
I've attached screenshots for reference.
before

after

The issue was resolved after configuring the provider for 'Translate Text' in the AI default settings.

Hi marcus_johansson,

We've removed the AiTranslateForm.php file, and I'm able to translate content without any issues.
I've attached a reference video for your review.

I will test the functionality.

Updated the $time property type in ContentTranslationControllerOverride to match the parent class (ContentTranslationController). The parent class defines it as TimeInterface, so it cannot be overridden as ?TimeInterface due to strict type compatibility in PHP. This change resolves the type mismatch error and maintains proper inheritance.

prabha1997 → made their first commit to this issue’s fork.

prabha1997 → changed the visibility of the branch 3482645-copy-reference-translated-entity to active.

prabha1997 → changed the visibility of the branch 3482645-copy-entity-reference to hidden.

prabha1997 → changed the visibility of the branch 3482645-copy-reference-translated-entity to hidden.

prabha1997 → changed the visibility of the branch 3482645-copy-reference-translated-entity to active.

prabha1997 → changed the visibility of the branch 1.0.x to hidden.

prabha1997 → changed the visibility of the branch 3482645-copy-reference-translated-entity to hidden.

prabha1997 → changed the visibility of the branch 3482645-ai-translate-module to hidden.

prabha1997 → made their first commit to this issue’s fork.

prabha1997 → made their first commit to this issue’s fork.

Hi @marcus_johansson,
I'm currently unable to access the spreadsheet — it looks like I don't have permission. Could you please grant me access?
Thanks!

Hi @marcus_johansson,
The previous merge request was created against the 1.0.x branch. I’ve now created a new branch based on the 1.1.x branch.
Kindly review it. Thanks!

prabha1997 → changed the visibility of the branch 3482645-copy-entity-reference to active.

prabha1997 → changed the visibility of the branch 3482645-copy-entity-reference to hidden.

Yes, You can close this issue as "Won't do", since #3521499 addresses the concern.

Thank you for your feedback.
I've now added the following assertion to cover the invalid email case with a space:
$this->assertFalse($validator->isValid('example @example.com'));
Please let me know if any further changes are needed.

Thank you for the feedback! As of now, I’m getting the default models from the plugin and have set them dynamically like this. Please review this approach. I understand your point about editorial choices, and regarding bumping models to GPT-4.1, we can wait until the tests with Drupal CMS are completed. Once we have more insights, we can make the necessary changes.

Hello @ishani,

Thank you for checking the 1.1.x branch.

You're right — I reviewed it on my end, and the "Use source vocabulary" field does appear when a content type includes a taxonomy reference field. In my earlier test, I had created a node type without any taxonomy reference field, which is why the option was not visible.

I also verified this with the Article content type, which uses its own tag vocabulary — and as expected, the field was available.

Thanks again for the clarification!

I have tested this issue. Please review the before and after screenshots below for reference.

I have tested this issue. Please review the before and after videos below for reference.

Thanks @AnjaliPrasannan it is working now as expected

I’ve created a new issue to track this and I’m tagging it here for reference.
https://www.drupal.org/project/ai/issues/3523519 🐛 The "Use source vocabulary" field is currently missing from the AI Content Suggestions section when editing content. Active

prabha1997 → created an issue.

This issue has been fixed in the 1.0.x branch.
However, in the 1.1.x branch, the "Use source vocabulary" field is missing.

I’ve added a dynamic implementation to set the default provider and model ID for each operation type.

I’ve tested all explorers after the changes, and everything is working as expected.

I tried it on 1.1.x of ai branch, and it is working as expected. Please refer to the attached screenshot for reference.

prabha1997 → made their first commit to this issue’s fork.

prabha1997 → made their first commit to this issue’s fork.

prabha1997 → made their first commit to this issue’s fork.

prabha1997 → made their first commit to this issue’s fork.

Created a merge request from the patch.

prabha1997 → made their first commit to this issue’s fork.

prabha1997 → made their first commit to this issue’s fork.

I've resolved the merge conflicts on this MR.

prabha1997 → made their first commit to this issue’s fork.

I have just added the accept attribute to the file input field to restrict the selectable file types in the file dialog. This improves the user experience by showing only supported formats (.jpg, .jpeg, .png) when choosing a file.

I checked this on the 1.1.x branch of the ai module, with the ai_provider_openai version set to 1.0.2. I was able to see the client-side validation error correctly triggered when the key was left empty.
Please refer to the attached screenshot for reference.

@jurgenhaas
In the 3.0.x branch, I noticed that the eca.install file was removed.
Since I need to add an update hook, is it okay to reintroduce the eca.install file, or is there a specific reason it was removed?

I have tested this locally and encountered the following issue:

Configuration: /var/www/html/core/phpunit.xml.dist

F                                                                   1 / 1 (100%)

Time: 00:10.017, Memory: 4.00 MB

There was 1 failure:

1) Drupal\Tests\Core\Recipe\RecipeQuickStartTest::testQuickStartRecipeCommand
Failed asserting that ' 0/16 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]\n
Installing Drupal\n
\n
 5/16 [▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░░░░]\n
Set up database\n
\n
 7/16 [▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░]\n
Set up database\n
\n
10/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░]\n
Configure site\n
\n
In install.core.inc line 980:\n
                                                                                                                  \n
  The email address <em class="placeholder">drupal@localhost</em> is not valid. Use the format user@example.com.  \n
  The email address <em class="placeholder">admin@localhost</em> is not valid. Use the format user@example.com.   \n
                                                                                                                  \n
\n
quick-start [--langcode [LANGCODE]] [--password [PASSWORD]] [--site-name [SITE-NAME]] [--host [HOST]] [--port [PORT]] [-s|--suppress-login] [--] [<install-profile-or-recipe>]\n
\n
' [UTF-8](length: 1108) contains "Congratulations, you installed Drupal!" [ASCII](length: 38).

/var/www/html/core/tests/Drupal/Tests/Core/Recipe/RecipeQuickStartTest.php:119

FAILURES!
Tests: 1, Assertions: 2, Failures: 1.

prabha1997 → made their first commit to this issue’s fork.

prabha1997 → made their first commit to this issue’s fork.

I've updated the test to include a check for the actual field type, so it now only runs if the changed field uses the real 'changed' type (not the changed_test).

I tried to add validation for the ChangedItem field as shown below, but I am not getting the expected validation failure for the invalid changed timestamp.

 if ($entity instanceof \Drupal\Core\Entity\EntityChangedInterface && $entity->hasField('changed')) {
      // This entity has a 'changed' field. You can now safely test it.
      $test_entity = clone $entity;
      $test_entity->set('changed', -2147483649);  // Invalid timestamp (below min range)
      // Validate the entity.
      $violations = $test_entity->validate();
      $this->assertEquals(1, $violations->count(), 'Validation failed for invalid changed timestamp.');
      $this->assertEquals('The changed timestamp is out of the valid range.', $violations[0]->getMessage());

      // Valid 'changed' timestamp.
      $test_entity->set('changed', 1234567890);  // Valid timestamp
      $violations = $test_entity->validate();
      $this->assertEquals(0, $violations->count(), 'Valid changed timestamp passed validation.');
    }

I am working on this issue

I've given it a try, but I'm having some difficulty getting it to work as expected. I haven't been able to achieve the correct results yet.

@jurgenhaas I have updated the description text to use a clearer example, where the index and the value are different to avoid confusion.

Hi, thanks for pointing that out! I’ve rebased the MR again and resolved the conflicts. Could you please check if the issue still persists? Let me know if anything else needs to be adjusted.

prabha1997 → made their first commit to this issue’s fork.

Thanks for the clarification. I may have misunderstood the original requirement — I had implemented it as a separate action. Based on your input, I’ll work on updating the existing Entity: set field value action to include an additional 'Empty field' method instead.

I've added the Empty field value action plugin. It supports both single and multi-value fields, allows token usage for field names, and clears the field value correctly.

Let me know if any changes are needed. Thanks for reviewing!

I am working on this issue

Thanks @mxh for the detailed feedback!
I’ve updated the MR to reflect the suggested changes:
Renamed the option from "Skip language prefix" to "Use internal path".
Updated the description to make it more general, not just about language prefixes.
Please have a look and let me know if any further changes are needed.

I’ve re-added the skip_language_prefix option and updated the logic to use the internal path only when this option is enabled. Existing configurations will continue to work with the original logic.

Please have a look and let me know if any further changes are needed.

I have updated the MR as per @mxh review comments

I am working on this issue

I have checked this issue — it works as expected in the Claro theme. However, the issue only occurs when using the Gin theme.

@jurgenhaas with out storing token value it will work
here i have implemented same model please check this

whenever i try to visit node alias page we are able to see only

div & span

wrappers but not able to find

ol & li

tag that's why test case failed

prabha1997 → made their first commit to this issue’s fork.

@kristiaanvandeneynde
I’m new to writing test cases at the moment, I’m exploring why the test is failing locally. I’m working on understanding and resolving the issue. Apologies for any inconvenience caused.

prabha1997 → made their first commit to this issue’s fork.

prabha1997 → made their first commit to this issue’s fork.

I am trying to change the target branch but not able to do that.