- Issue created by @mgifford
- ๐ฎ๐ณIndia prashant.c Dharamshala
prashant.c โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia prashant.c Dharamshala
Raised the MR against
1.1.x
by fixing the logic to handle the Ajax loading of models per provider. Changes need to be reviewed. - ๐ฉ๐ชGermany marcus_johansson
There seems to be some phpcs and phpstan issues that needs fixing. I think a merge with 1.1.x should fix the phpunit issues.
- ๐ฎ๐ณIndia prabha1997
Hi @marcus_johansson,
The previous merge request was created against the 1.0.x branch. Iโve now created a new branch based on the 1.1.x branch.
Kindly review it. Thanks! - ๐ฉ๐ชGermany marcus_johansson
Hi prabha1997 - the problem right now is that the functional testing is failing, where a model should be selectable. The form should have graceful fallback, so it works also without JS. Would that be possible to add in the current solution?
- ๐ฎ๐ณIndia prabha1997
prabha1997 โ changed the visibility of the branch 3521769--ai-settings to hidden.
- ๐ฎ๐ณIndia prashant.c Dharamshala
A couple of points that need to be addressed:
1. Ai Search Setup My Sql (Drupal\Tests\ai_search\Functional\AiSearchSetupMySql)
โ Field indexing options
โ Search view
โ
โ Exception: Warning: Undefined array key "title"
โ Drupal\views\Views::fetchPluginNames()() (Line: 157)2. "Choose Model" should not appear when there is no provider available in the "Default Provider" select list for example in Image classification operation type
- ๐ฎ๐ณIndia prashant.c Dharamshala
The following warning seems unrelated to the current MR :
1. Ai Search Setup My Sql (Drupal\Tests\ai_search\Functional\AiSearchSetupMySql)
โ Field indexing options
โ Search view
โ
โ Exception: Warning: Undefined array key "title"
โ Drupal\views\Views::fetchPluginNames()() (Line: 157)Kindly rebase and move it to NR.
- ๐ฎ๐ณIndia annmarysruthy
Reviewed the MR and tested the changes. Found an issue:
- On changing the Default provider from a valid provider to 'No Default', the dropdown in 'Default model' changes is empty , instead of '-select-' being displayed
- ๐ฎ๐ณIndia Kanchan Bhogade
Hi @annmarysruthy
I have tested MR on Drupal 11.x, and it was applied successfully.Upon changing the default provider from a selected valid provider to 'No Default', the dropdown reverts to showing the placeholder '-select-' instead of retaining a selected value.
Attaching reference file