- Issue created by @wouters_f
- Assigned to kevinquillen
- Merge request !49fix: handle 'undefined' types and treat them as newlines. β (Open) created by kevinquillen
- πΊπΈUnited States kevinquillen
This was a bug in the way the JS code was interpreting the selection data.
undefined
is now treated as newline characters.This is a short term fix, in the future the model should be preserved now that it can respond with HTML. Try out this branch.
- Status changed to Needs review
5 months ago 12:33am 26 August 2024 - π§πͺBelgium wouters_f Leuven
I've also tested this on the main branch 1.0.x and the error is not occurring there anymore (unless I'm mistaken).
In that case we can just close this issue. - Issue was unassigned.
- π΅πΉPortugal developer-rocha
In version 1.0.0-alpha7, the issue with the "undefined" message still persists. Additionally, I'm encountering another problem: I can no longer generate any results. When the modal opens, a select input appears for choosing the tone (taxonomy term), but after selecting an option, nothing happens. No logs are generated regarding the error.
- π©πͺGermany marcus_johansson
@developer-rocha - the undefined is not merged yet, its still in draft, but for the other part - could you give back which providers/models your are using and how you setup the taxonomy?
I recorded this video yesterday, if it help with how to set it up: https://www.youtube.com/watch?v=CUjZ4HQTZ14
- π΅πΉPortugal developer-rocha
@marcus_johansson - I have the correct configuration. But I've noticed that whether it's translating, creating text or changing the tone, my modal doesn't show the generate button. Therefore, I believe the problem is related to the Modal form. I'm going to investigate further to try to find out the reason for the problem.
I'm using OpenAI / model: gtp-4o
- π©πͺGermany marcus_johansson
@developer-rocha - there should be general settings for the Modal form. Since the two buttons are in the bottom, they might maybe overlapse the screen height? Maybe try to hardcode a height value and see what happens.
- π΅πΉPortugal developer-rocha
@marcus_johansson - The buttons were actually hidden. However, I think we should put a default option where the scroll works on the entire modal. I've made some changes to the CSS to ensure that the scroll works on the entire modal and not just on the ui-dialog-content and I've also adjusted the CSS that is applied to the ui-dialog-content, changing the height to auto instead of a value calculated by the total height of the modal.
I created a patch for this.
- πΊπΈUnited States kevinquillen
That patch is unrelated to the original issue and should be in its own separate issue.
But going back to the original MR, I have rebased it with upstream changes from 1.0.x. It should preserve everything that was selected now (HTML tags):