- First commit to issue fork.
- Assigned to shivam_tiwari
- @shivam_tiwari opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:10am 4 April 2023 - Assigned to psf_
- Status changed to Needs work
about 1 year ago 9:03am 27 October 2023 - 🇪🇸Spain psf_ Huelva
The patch in #9 don't work for me.
To do the work I need to change
autoPlaceholder: "polite",
to
autoPlaceholder: "off",
in
js/phone_international.js
I will try to do a new patch.
- @psf_ opened merge request.
- 🇪🇸Spain psf_ Huelva
New updated patch in https://git.drupalcode.org/project/phone_international/-/merge_requests/... , MR 12 in this issue.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:26am 27 October 2023 - First commit to issue fork.
- 🇮🇳India nayana_mvr
The previous patch was not getting applied. It was showing the following error:-
Checking patch js/phone_international.js... error: while searching for: }, preferredCountries: preferred ? preferred.split("-") : [], nationalMode: true, autoPlaceholder: "aggressive", formatOnDisplay: true, hiddenInput: "full_number", utilsScript: drupalSettings.phone_international.path + "/js/utils.js", error: patch failed: js/phone_international.js:28 error: js/phone_international.js: patch does not apply Checking patch src/Element/PhoneInternationalElement.php... Checking patch js/phone_international.js... error: while searching for: }, preferredCountries: preferred ? preferred.split("-") : [], nationalMode: true, autoPlaceholder: "polite", formatOnDisplay: true, hiddenInput: "full_number", utilsScript: drupalSettings.phone_international.path + "/js/utils.js", error: patch failed: js/phone_international.js:28 error: js/phone_international.js: patch does not apply Checking patch src/Element/PhoneInternationalElement.php... Hunk #1 succeeded at 152 (offset 3 lines).
So created a new MR in which I have added a new field in the widget settings to input custom placeholder which will be displayed in the input field. Kindly review.