🇪🇸Spain @psf_

I agree with #6, +1 to this issue.

Hi, I tried my patch in D11.1, and it didn't work. I see that the field data is in the _field_data table, but in D10.4, it is in the table.

Is it accurate?

It's been five years since I opened this issue, so I don't fully recall all the details. However, I believe the non-minified version of jquery.barrating.js was used to make debugging easier rather than being strictly required to fix the issue. Let me know if any further clarification is needed!

Hi,

Must be the status changed to "Reviewed & tested by the community"?

From What to expect from the review process → :

Once all issues have been addressed:

The reviewers will change the status of the issue to Reviewed & tested by the community
After that, a project moderator will validate the review, granting the applicants the role to be able to opt projects into security advisory coverage, and changing the status of the application to Fixed. If new issues are identified, the status could be set back to Needs work.

I think that only need tests.

I have it working : )

Hi, I will try to add base fields support. : )

psf_ → made their first commit to this issue’s fork.

psf_ → created an issue.

Hello,

Thank you for your detailed response! I now understand the distinction between the DSFR source code (which is open) and the DSFR design (which is restricted to French government websites).

I would like to clarify one more point:
👉 If I use this Drupal theme but modify the design so that my website cannot be confused with a French public administration, would this be considered an allowed use?

In other words:

If I change branding elements (such as logos, colors, typography, etc.) so that my site clearly does not resemble an official government website,
But still use the base Drupal theme and the DSFR components in a way that does not suggest affiliation with the French administration,

Would this be compliant with the terms of use?

Thanks again for your help! 😊

psf_ → created an issue.

I found a module that add this functionality and more: →

Hi, the patch require update composer.json too, I think :)

Thx : )

Hi, I fixed all, I think :_ D

[X] 1. Fix phpcs issues.
- I ignored query.txt because it contains chat dump data.
- Fix openai_client/src/OpenAIClientWrapper.php
[X] 2. FILE: openai_client.info.yml
- I Changed package to "AI", how in the module ai/ of the "AI Initiative".
[X] 3. FILE: openai_client.module
[X] 4. FILE: src/Controller/AssistantsListController.php
[X] FILE: src/Form/AssistantEditForm.php
[X] 5. FILE: src/Controller/AssistantsListController.php
[X] 6. FILE: src/Controller/AssistantsListController.php
[X] FILE: src/Form/AssistantEditForm.php
[X] FILE: src/Form/CreateImageForm.php
[X] FILE: src/Form/SettingsForm.php
[X] 7. FILE: src/Form/SettingsForm.php
[X] FILE: openai_client.info.yml

Thanks for review `.gitlab-ci.yml` : )

Thank you so much! 😊

I will fix the issues as soon as possible.

Do you have any suggestions for the .gitlab-ci.yml configuration? I have set it up, but it doesn’t detect the failures.
Here is the pipeline: https://git.drupalcode.org/project/openai_client/-/pipelines/428605

Hello,

I would like to become the maintainer of the Maintenance Mode Exclude Urls module.

I have successfully updated the module to work with Drupal 10 and would like to ensure its continued maintenance and compatibility with future Drupal versions. As I am already using this module in my own projects, I am committed to keeping it up to date and addressing any issues that arise.

Additionally, I have already submitted an issue to obtain the security coverage opt-in permission.
https://www.drupal.org/project/projectapplications/issues/3507722 📌 [1.1.x] OpenAI Client Needs review

Please let me know if there are any further steps I need to take.

Best regards,
Pedro Peláez
psf_

psf_ → created an issue.

psf_ → created an issue.

Merged, thx : ))

Hi, I added you : )

Thx

Hi,

#10 works for me using "ace_editor" 2.0.1 on Drupal 10.3.10.

Before installing the patch, the "ace formatter" didn't display themes, and there was no syntax highlighting.

I think that the problem is the base fields don't have Field Storage.

If I execute:

$fieldStorage = \Drupal::entityTypeManager()
      ->getStorage('field_storage_config');
    $fields = $fieldStorage->loadMultiple();

$fields don't have any base fields.

Hi,

Notes that may light somebody.

I found why the default type is string to datetime basefields. In web/core/modules/views/views.views.inc we have a switch that set it how string:

// Expose data for each field property individually.
  foreach ($field_columns as $column => $attributes) {
    $allow_sort = TRUE;

    // Identify likely filters and arguments for each column based on field type.
    switch ($attributes['type']) {
      case 'int':
      case 'mediumint':
      case 'tinyint':
      case 'bigint':
      case 'serial':
      case 'numeric':
      case 'float':
        $filter = 'numeric';
        $argument = 'numeric';
        $sort = 'standard';
        if ($field_storage->getType() == 'boolean') {
          $filter = 'boolean';
        }
        break;

      case 'blob':
        // It does not make sense to sort by blob.
        $allow_sort = FALSE;
      default:
        $filter = 'string';
        $argument = 'string';
        $sort = 'standard';
        break;
    }
...

The datetime field type must not have a valid filter handler defined.

In datetime_type_field_views_data_helper(), in datetime core module, we have a comment that say:

// @todo This code only covers configurable fields, handle base table fields
// in https://www.drupal.org/node/2489476 → .

Updated to Drupal 10.3.10:

services:
  # Allow use string how twig templates.
  twig.extension.stringloader:
    class: Twig\Extension\StringLoaderExtension
    tags:
      - { name: 'twig.extension' }

+1 : )

Updated issue status, I changed it before by mistake.

Merged and released in v1.0.4 : )

With drush I can remove the versión number to refresh the table:

$ drush config:set browscap.settings version 0

I just checked the ddev installation, and now the database is empty, too. :/ I don't know why.

psf_ → created an issue.

Thx to u :_ D

@juandels3 , please, could you release the 1.0.x-dev branch?

I fix a minimal style issue in README.md.

I added a output to the field formatter.

I extend the field widget to allow select any bundable content entity type in widget settings.

psf_ → created an issue.

Yes, I've already changed it, it was hard to find where... I found instructions in the issue of another project https://www.drupal.org/project/form_mode_manager/issues/3399176 📌 Set correct default branch (8.x-2.x) in GitLab Fixed

Regards :)

In the hook_ENTITY_TYPE_predelete PHPStan fail with the message:

Call to deprecated method deleteRevision() of interface
Drupal\Core\Entity\EntityStorageInterface:
in drupal:10.1.0 and is removed from drupal:11.0.0. Use
\Drupal\Core\Entity\RevisionableStorageInterface::deleteRevision instead.

We only need add a var type comment to the $storage variable:

  // Delete checkout country alerts that belong to this account.
  /** @var \Drupal\Core\Entity\RevisionableStorageInterface $storage */
  $storage = \Drupal::entityTypeManager()->getStorage('my_custom_entity');

I added "/** @var" line, and PHPStan go OK.

I see it OK, but I don't tested it.

I'm so busy, when I get free I will try it, or apply it if anyother tested it.

Thx so much

fjgarlin → credited psf_ → .

I get the issue error so many times in my site, and I don't know why. I started to see it after update to D10.1, or D10.2. I added the patch from the MR 6299, and it not fix my errors:

Warning: Undefined array key "function" in Drupal\Core\Utility\Error::decodeException() (line 70 of core/lib/Drupal/Core/Utility/Error.php).

Drupal\Core\Utility\Error::decodeException(Object) (Line: 69)
Drupal\Core\EventSubscriber\ExceptionLoggingSubscriber->onError(Object) (Line: 118)
Drupal\Core\EventSubscriber\ExceptionLoggingSubscriber->onException(Object, 'kernel.exception', Object)
call_user_func(Array, Object, 'kernel.exception', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.exception') (Line: 239)
Symfony\Component\HttpKernel\HttpKernel->handleThrowable(Object, Object, 1) (Line: 91)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 53)
Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

We are using D10.3.2, update many times from D9.5, with Olivero subtheme, and so many custom and contrib modules.

Sorry for not get more information, I hope that this trace get the trick.

I do the change by Chris64 in #19.

I'm sorry, I don't know how do the interdiff.

Hi, thanks for the offer. I've already added you as a co-maintainer. I believe I've given you the necessary permissions, if you need anything else just ask.

Fixed in https://git.drupalcode.org/project/javascript_scripting/-/commit/27be5f2...

After a clean install we get this error.

The contrib module csv_imported is affected the same way of core.

Issue: https://www.drupal.org/project/csv_importer/issues/3468099#comment-15743933 💬 No available releases found with Drupal 10.3.2 Active

We have a issue open in core: https://www.drupal.org/project/drupal/issues/3470230 🐛 No available releases found Active

I see the same error with Drupal core 10.3.1. The not available version message appear in this module and in core. Maybe a problem with the update service and not with this module?

psf_ → created an issue.

Fix conflicts with 8.x-1.x branch.

The last commit fix the comment #13.

#45 work for me too.

Hi, thx by the report.

I just upload a new update to the DEV branch, could you try it?

In this line:
$token = empty($token) ? $this->getApiToken() : '';

"$this->getApiToken()" can return a NULL value if the user don't configure the module.

I change your commit with:

public function getClient(string $token = ''): Client {
    if (empty($token)) {
      $token = $this->getApiToken();
    }
    $token = !$token ? '' : $token;
    return \OpenAI::client($token);
  }

But I don't tested it.

Merged, thx : ))

Hi,

The library that we use to connect to OpenAI have compatiblity with tests: https://github.com/openai-php/client?tab=readme-ov-file#testing

But I don't have time to implement it, can anyone create tests?

Hi, thx by the patch.

I have some notes:

- In "src/OpenAIClientWrapper.php" you were erased all comments, it's are required by code styling that we have comments.
- In the protected method getApiToken() we can't send any status message, because that will spawn the user with messages. This method is called so many times.

psf_ → made their first commit to this issue’s fork.

I see, thx : ) It's merged

Hi @aman_lnwebworks,

Thx by the patch.

What PHP version are you using?

Is this issue about Drupal core? I don't see relation between system.date/country.default and currency module.

psf_ → created an issue.

Hi, I want to note that the workaround does not work with custom entities that have field groups in them.

Great solution in #8. Maybe it should be added to the documentation?

psf_ → created an issue.

Hi, I will anote some related information. :)

Workaround: https://drupal.stackexchange.com/questions/253978/how-do-i-allow-full-ht...

+1 here :) . I'm using Drupal 10.2.5

alvar0hurtad0 → credited psf_ → .

+1

Thx : )

Thx :)

If we have more that one importer for a entity type, the "Select importer" input don't filter by permissions.

After select entity type the module display a select with all plugins of selected entity type.

Sorry :_ D

psf_ → created an issue.

Work for me, but it need a bit of debug.

I'll move the 'CSV Importer' menu link from the 'Configuration > Development' section to the 'Content' section to improve accessibility and relevance. This change aligns the import feature with content-related functionalities, making it more intuitive for content editors and administrators who commonly use this feature as part of their content workflows.