Contrib.social

Fivestar accesibility issue

Open on Drupal.org →
Created on 3 September 2019, over 5 years ago
Updated 14 September 2024, 6 months ago

Problem/Motivation

The widget fivestar output generates two fails when I pass the WAVE test.
* One is the requirement of a label tag for the select that is the stars base form.
* Other is that the A tags must have a text, by default jquery-bar-rating don't show it. We must set the "showValues" option to true.
(I do a pull request to the github project to add a span tag to that texts, and we can hide it when required: https://github.com/antennaio/jquery-bar-rating/pull/123)

Proposed resolution

The first is a core problem, I can't do anything here. (In my project I overwrote the select.html.twig in my custom theme.)
The second can be accomplished by adding showValues: true to fivestar.js options, I will upload a patch, and adding the display:none css rule required to not change the current user interface.

Remaining tasks

I tested this in local with fivestar only, the patch may require some extra work.

User interface changes

If the patch is Ok, not required.

API changes

N/A

Data model changes

N/A

✨ Feature request
Status

Needs work

Version

2.0

Component

Theming

Created by

🇪🇸Spain psf_ Huelva

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 6 months ago →
    🇺🇸United States tr Cascadia
  • Comment 14 days ago →
    🇺🇸United States tr Cascadia

    I re-rolled the patch in #2 so that it would apply to the 2.0.x branch, and I created an MR for it so that we could run testing on the patch.

    I have not evaluated this. This needs a test to demonstrate the problem and to prove the patch fixes the problem.

    Why was the minified version of jquery.barrating.js replaced with the verbose version? Is this only for debugging, or is it required to fix the problem?

  • Merge request !30Issue #3078950 by psf_: Fivestar accesibility issue → (Open) created by tr
  • Comment 11 days ago →
    🇪🇸Spain psf_ Huelva

    It's been five years since I opened this issue, so I don't fully recall all the details. However, I believe the non-minified version of jquery.barrating.js was used to make debugging easier rather than being strictly required to fix the issue. Let me know if any further clarification is needed!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024