Fivestar accesibility issue

Created on 3 September 2019, about 5 years ago
Updated 14 September 2024, 2 months ago

Problem/Motivation

The widget fivestar output generates two fails when I pass the WAVE test.
* One is the requirement of a label tag for the select that is the stars base form.
* Other is that the A tags must have a text, by default jquery-bar-rating don't show it. We must set the "showValues" option to true.
(I do a pull request to the github project to add a span tag to that texts, and we can hide it when required: https://github.com/antennaio/jquery-bar-rating/pull/123)

Proposed resolution

The first is a core problem, I can't do anything here. (In my project I overwrote the select.html.twig in my custom theme.)
The second can be accomplished by adding showValues: true to fivestar.js options, I will upload a patch, and adding the display:none css rule required to not change the current user interface.

Remaining tasks

I tested this in local with fivestar only, the patch may require some extra work.

User interface changes

If the patch is Ok, not required.

API changes

N/A

Data model changes

N/A

✨ Feature request
Status

Needs work

Version

2.0

Component

Theming

Created by

πŸ‡ͺπŸ‡ΈSpain psf_ Huelva

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024